Re: [PATCH] update checkpatch.pl to version 0.10

Andy Whitcroft
2007-09-28T09:23:01Z

On Fri, Sep 28, 2007 at 02:01:32AM -0700, Andrew Morton wrote:
> On Fri, 28 Sep 2007 10:40:03 +0200 Ingo Molnar <mingo@elte.hu> wrote:
>
> > i ran it over kernel/sched.c and there are many bogus warnings that i
> > reported to you earlier:
> >
> > WARNING: multiple assignments should be avoided
> > #2319:
> > + max_load = this_load = total_load = total_pwr = 0;
>
> That warning is non-bogus, although this is one of the bogosities which
> I personally don't bother fixing or making a fuss about.
>
> But I do think it detracts from the readability of the code, and from
> patches which later alter that code. A bit.

I tend to agree, watching the automatic replies from checkpatch, the
majority of these are "justifiable" in their context. I think I'll
lower this one to a CHECK in the next release.

-apw