public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Len Brown <lenb@kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	simon.derr@bull.net, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] (repost) Fix SMP poweroff hangs
Date: Fri, 28 Sep 2007 15:53:19 -0400	[thread overview]
Message-ID: <46FD5BAF.8040304@rtr.ca> (raw)
In-Reply-To: <1190991316.18681.38.camel@chaos>

Rafael J. Wysocki wrote:
> ..
>> @@ -879,6 +880,7 @@
>>  	if (pm_power_off_prepare)
>>  		pm_power_off_prepare();
>>  	sysdev_shutdown();
>> +	disable_nonboot_cpus();
> 
> Before sysdev_shutdown(), please.
> 
> sysdev_shutdown() may touch things that belong to CPU0.

Thanks.  Here is the revised patch.

* * *

We need to disable all CPUs other than the boot CPU (usually 0)
before attempting to power-off modern SMP machines.
This fixes the hang-on-poweroff issue on my MythTV SMP box,
and also on Thomas Gleixner's new toybox.

Signed-off-by: Mark Lord <mlord@pobox.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
---

--- linux/kernel/sys.c.orig	2007-09-13 09:49:11.000000000 -0400
+++ linux/kernel/sys.c	2007-09-28 15:48:54.000000000 -0400
@@ -32,6 +32,7 @@
 #include <linux/getcpu.h>
 #include <linux/task_io_accounting_ops.h>
 #include <linux/seccomp.h>
+#include <linux/cpu.h>
 
 #include <linux/compat.h>
 #include <linux/syscalls.h>
@@ -878,6 +879,7 @@
 	kernel_shutdown_prepare(SYSTEM_POWER_OFF);
 	if (pm_power_off_prepare)
 		pm_power_off_prepare();
+	disable_nonboot_cpus();
 	sysdev_shutdown();
 	printk(KERN_EMERG "Power down.\n");
 	machine_power_off();

  reply	other threads:[~2007-09-28 19:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27 21:29 Problems with SMP & ACPI powering off Mark Lord
2007-09-27 21:30 ` Mark Lord
2007-09-27 22:00 ` Rafael J. Wysocki
2007-09-27 23:07   ` Mark Lord
2007-09-28  4:57   ` Len Brown
2007-09-28 12:55     ` Rafael J. Wysocki
2007-09-28 13:22       ` Mark Lord
2007-09-28 13:44         ` Rafael J. Wysocki
2007-09-28 13:46           ` Mark Lord
2007-09-28 13:52             ` [PATCH] disable non-boot CPUs before poweroff Mark Lord
2007-09-28 14:11               ` Mark Lord
2007-09-28 14:55               ` Thomas Gleixner
2007-09-28 19:53                 ` Mark Lord [this message]
2007-09-30  9:00                   ` [PATCH] (repost) Fix SMP poweroff hangs Santiago Garcia Mantinan
2007-09-30 17:21                     ` Mark Lord
2007-09-30 17:54                       ` Santiago Garcia Mantinan
2007-09-30 18:47                         ` Mark Lord
2007-09-30 20:03                           ` Santiago Garcia Mantinan
2007-09-30 22:52                             ` 32-bit Athlon X2 won't poweroff (was: Fix SMP poweroff hangs) Mark Lord
2007-09-30 22:56                               ` 32-bit Athlon X2 won't poweroff Mark Lord
2007-10-01 16:19                               ` 32-bit Athlon X2 won't poweroff (was: Fix SMP poweroff hangs) Santiago Garcia Mantinan
2007-10-01 16:37                                 ` 32-bit Athlon X2 won't poweroff Mark Lord
2007-10-01 20:05                         ` [PATCH] (repost) Fix SMP poweroff hangs Rafael J. Wysocki
2007-10-01 22:38                           ` Santiago Garcia Mantinan
2007-09-28 15:05               ` [PATCH] disable non-boot CPUs before poweroff Rafael J. Wysocki
2007-09-28 15:02                 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FD5BAF.8040304@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=akpm@osdl.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=simon.derr@bull.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox