linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quan Xu <quan.xu0@gmail.com>
To: Liran Alon <LIRAN.ALON@ORACLE.COM>,
	Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: jmattson@google.com
Subject: Re: [PATCH] KVM: nVMX: remove unnecessary vmwrite from L2->L1 vmexit
Date: Wed, 3 Jan 2018 14:32:28 +0800	[thread overview]
Message-ID: <46aac22a-7ffd-c839-c203-ee68c502e20e@gmail.com> (raw)
In-Reply-To: <5A4B551E.2020603@ORACLE.COM>



On 2018/01/02 17:47, Liran Alon wrote:
>
>
> On 02/01/18 00:58, Paolo Bonzini wrote:
>> The POSTED_INTR_NV field is constant (though it differs between the 
>> vmcs01 and
>> vmcs02), there is no need to reload it on vmexit to L1.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>   arch/x86/kvm/vmx.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index e6223fe8faa1..1e184830a295 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -11610,9 +11610,6 @@ static void load_vmcs12_host_state(struct 
>> kvm_vcpu *vcpu,
>>            */
>>           vmx_flush_tlb(vcpu, true);
>>       }
>> -    /* Restore posted intr vector. */
>> -    if (nested_cpu_has_posted_intr(vmcs12))
>> -        vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR);
>>
>>       vmcs_write32(GUEST_SYSENTER_CS, vmcs12->host_ia32_sysenter_cs);
>>       vmcs_writel(GUEST_SYSENTER_ESP, vmcs12->host_ia32_sysenter_esp);
>>
>
> Reviewed-by: Liran Alon <liran.alon@oracle.com>
>
> I would also add to commit message:
> Fixes: 06a5524f091b ("KVM: nVMX: Fix posted intr delivery when vcpu is 
> in guest mode")
>
Reviewed-by: Quan Xu <quan.xu0@gmail.com>

      reply	other threads:[~2018-01-03  6:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01 22:58 [PATCH] KVM: nVMX: remove unnecessary vmwrite from L2->L1 vmexit Paolo Bonzini
2018-01-02  0:45 ` Jim Mattson
2018-01-02  9:47 ` Liran Alon
2018-01-03  6:32   ` Quan Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46aac22a-7ffd-c839-c203-ee68c502e20e@gmail.com \
    --to=quan.xu0@gmail.com \
    --cc=LIRAN.ALON@ORACLE.COM \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).