From: Tom Rix <trix@redhat.com>
To: Joerg Vehlow <lkml@jv-coder.de>,
linux-kernel@vger.kernel.org, bigeasy@linutronix.de
Cc: Joerg Vehlow <joerg.vehlow@aox-tech.de>
Subject: Re: [PATCH RT v3] net/xfrm/input: Protect queue with lock
Date: Tue, 26 Nov 2019 07:31:56 -0800 [thread overview]
Message-ID: <46d5e7ea-011b-a384-ac7a-9ba63bbe9ea5@redhat.com> (raw)
In-Reply-To: <20191126071335.34661-1-lkml@jv-coder.de>
Why remove the #ifdef CONFIG_PREEMPT.. ?
> + spin_lock_irqsave(&trans->queue.lock, flags);
> skb_queue_splice_init(&trans->queue, &queue);
> + spin_unlock_irqrestore(&trans->queue.lock, flags);
>
Fine otherwise.
Tom
next prev parent reply other threads:[~2019-11-26 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 7:13 [PATCH RT v3] net/xfrm/input: Protect queue with lock Joerg Vehlow
2019-11-26 8:40 ` Sebastian Andrzej Siewior
2019-11-26 15:31 ` Tom Rix [this message]
2019-11-27 7:35 ` Joerg Vehlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46d5e7ea-011b-a384-ac7a-9ba63bbe9ea5@redhat.com \
--to=trix@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=joerg.vehlow@aox-tech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@jv-coder.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox