From: Aradhya Bhatia <aradhya.bhatia@linux.dev>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Devarsh Thakkar <devarsht@ti.com>, Jyri Sarha <jyri.sarha@iki.fi>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jonathan Cormier <jcormier@criticallink.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 6/7] drm/tidss: Fix race condition while handling interrupt registers
Date: Sun, 24 Nov 2024 22:59:08 +0530 [thread overview]
Message-ID: <46d85c32-7181-4fdc-81fd-041f2f48957e@linux.dev> (raw)
In-Reply-To: <20241021-tidss-irq-fix-v1-6-82ddaec94e4a@ideasonboard.com>
On 10/21/24 19:37, Tomi Valkeinen wrote:
> From: Devarsh Thakkar <devarsht@ti.com>
>
> The driver has a spinlock for protecting the irq_masks field and irq
> enable registers. However, the driver misses protecting the irq status
> registers which can lead to races.
>
> Take the spinlock when accessing irqstatus too.
>
> Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display SubSystem")
> Cc: stable@vger.kernel.org
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> [Tomi: updated the desc]
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>
Regards
Aradhya
[...]
next prev parent reply other threads:[~2024-11-24 17:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 14:07 [PATCH 0/7] drm/tidss: Interrupt fixes and cleanups Tomi Valkeinen
2024-10-21 14:07 ` [PATCH 1/7] drm/tidss: Fix issue in irq handling causing irq-flood issue Tomi Valkeinen
2024-10-21 15:21 ` Jon Cormier
2024-11-24 17:18 ` Aradhya Bhatia
2024-11-25 11:08 ` Tomi Valkeinen
2024-10-21 14:07 ` [PATCH 2/7] drm/tidss: Remove unused OCP error flag Tomi Valkeinen
2024-11-22 8:00 ` Devarsh Thakkar
2024-11-24 17:19 ` Aradhya Bhatia
2024-10-21 14:07 ` [PATCH 3/7] drm/tidss: Remove extra K2G check Tomi Valkeinen
2024-11-22 8:00 ` Devarsh Thakkar
2024-11-24 17:20 ` Aradhya Bhatia
2024-10-21 14:07 ` [PATCH 4/7] drm/tidss: Add printing of underflows Tomi Valkeinen
2024-11-22 8:07 ` Devarsh Thakkar
2024-11-24 17:26 ` Aradhya Bhatia
2024-10-21 14:07 ` [PATCH 5/7] drm/tidss: Clear the interrupt status for interrupts being disabled Tomi Valkeinen
2024-10-21 15:13 ` Jon Cormier
2024-11-24 17:28 ` Aradhya Bhatia
2024-10-21 14:07 ` [PATCH 6/7] drm/tidss: Fix race condition while handling interrupt registers Tomi Valkeinen
2024-10-21 15:14 ` Jon Cormier
2024-11-24 17:29 ` Aradhya Bhatia [this message]
2024-10-21 14:07 ` [PATCH 7/7] drm/tidss: Rename 'wait_lock' to 'irq_lock' Tomi Valkeinen
2024-11-22 8:09 ` Devarsh Thakkar
2024-11-24 17:30 ` Aradhya Bhatia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46d85c32-7181-4fdc-81fd-041f2f48957e@linux.dev \
--to=aradhya.bhatia@linux.dev \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jcormier@criticallink.com \
--cc=jyri.sarha@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox