From: Avi Kivity <avi@qumranet.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andy Whitcroft <apw@shadowen.org>,
linux-kernel@vger.kernel.org
Subject: Re: checkpatch and kernel/sched.c
Date: Mon, 01 Oct 2007 09:48:25 +0200 [thread overview]
Message-ID: <4700A649.9020700@qumranet.com> (raw)
In-Reply-To: <20071001003007.4e90143b.akpm@linux-foundation.org>
Andrew Morton wrote:
>> this is actually a false positive - as the debug code constructs a
>> printk output _without_ \n. So the script should check whether there's
>> any \n in the printk string - if there is none, do not emit a warning.
>> (if you implement that then i think it can remain a warning and does not
>> need to move to CHECK.)
>>
>
> Yeah, it does that sometimes. I don't think it's fixable within the scope
> of checkpatch. It needs to check whether some preceding printk which might
> not even be in the patch has a \n:
>
> printk(KERN_ERR "foo");
> <100 lines of whatever>
> + printk("bar\n");
>
> we're screwed...
>
>
Isn't that broken on SMP (or with preemption) anyway?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2007-10-01 7:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070928105345.GC18163@shadowen.org>
2007-10-01 6:44 ` checkpatch and kernel/sched.c Ingo Molnar
2007-10-01 7:30 ` Andrew Morton
2007-10-01 7:48 ` Avi Kivity [this message]
2007-10-01 7:39 ` Andrew Morton
2007-10-01 10:39 ` Ingo Molnar
2007-10-01 7:50 ` Sam Ravnborg
2007-10-01 10:37 ` Ingo Molnar
2007-10-01 10:44 ` Ingo Molnar
2007-10-01 12:34 ` Andy Whitcroft
2007-10-02 4:34 ` Willy Tarreau
2007-10-02 5:18 ` [patch] printk: add KERN_CONT annotation Ingo Molnar
2007-10-02 10:04 ` Jörn Engel
2007-10-02 15:41 ` Joe Perches
2007-10-02 15:45 ` Jan Engelhardt
2007-10-02 16:03 ` Joe Perches
2007-10-02 16:07 ` Jan Engelhardt
2007-10-04 20:43 ` Andrew Morton
2007-10-04 20:52 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4700A649.9020700@qumranet.com \
--to=avi@qumranet.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox