Re: [TOMOYO 05/15](repost) Domain transition handler functions.

James Morris
2007-10-02T11:15:53Z

On Tue, 2 Oct 2007, Kentaro Takeda wrote:

> +
> + mb(); /* Instead of using spinlock. */
> + ptr = domain_initializer_list;
> + if (ptr) {
> + while (ptr->next)
> + ptr = ptr->next;
> + ptr->next = new_entry;
> + } else
> + domain_initializer_list = new_entry;
> +

Please use standard kernel list handling, per include/linux/list.h

Why do you need to avoid spinlocks for these manipulations?

- James
--
James Morris
<jmorris@namei.org>