From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbcBXNZf (ORCPT ); Wed, 24 Feb 2016 08:25:35 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:37962 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbcBXNZd convert rfc822-to-8bit (ORCPT ); Wed, 24 Feb 2016 08:25:33 -0500 X-AuditID: cbfee61b-f793c6d00000236c-2b-56cdaf4cd0ea From: Bartlomiej Zolnierkiewicz To: Caesar Wang Cc: Dinh Nguyen , Alexander Kochetkov , Vinod Koul , shawn.lin@rockchips.com, Addy Ke , Boojin Kim , dmaengine@vger.kernel.org, olof Johansson , "linux-kernel@vger.kernel.org" Subject: Re: commit 271e1b86e691 is breaking DMA uart on SoCFPGA Date: Wed, 24 Feb 2016 14:24:14 +0100 Message-id: <4702693.ayGVQyLr2V@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-74-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <56CD4757.4080501@gmail.com> References: <56BBB201.7060004@opensource.altera.com> <56CC775E.1020203@opensource.altera.com> <56CD4757.4080501@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=utf-8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t9jAV2f9WfDDL5fU7FY9v87k8WKfieL Nyf/sFks/LmO0WLVpzXMFqun/mW1uLxrDpvFqeuf2SyWHi63eNm3n8WBy2PnrLvsHov3vGTy uHKiidWj/9okdo+/s/azeDyf/JDFo2/LKkaPz5vkAjiiuGxSUnMyy1KL9O0SuDI23ZvNXPCa t2JP40TGBsarXF2MHBwSAiYSa3cEdjFyApliEhfurWfrYuTiEBJYyihxbOk9FgjnK6PErdvf 2UGq2ASsJCa2r2IEsUUEtCWurbvDDFLELPCYSeLSy/ksIFOFBRwkVn/0AjFZBFQljh9TAinn FdCUaDzVD9YqKuAlsePObiYQmxMo/nRNK9h4IYEaic2te1gh6gUlfkwGuYETaLy2xJN3F1hB RjILqEtMmZI7gVFgFpKqWUiqZiFULWBkXsUokVqQXFCclJ5rlJdarlecmFtcmpeul5yfu4kR HB3PpHcwHt7lfohRgINRiYf3wYYzYUKsiWXFlbmHGCU4mJVEeOOmnQ0T4k1JrKxKLcqPLyrN SS0+xCjNwaIkzvv4/7owIYH0xJLU7NTUgtQimCwTB6dUA+MWNVsFjatlSTOKXi5Is5LOagl6 nR4578PSV5a7Ih8Z8pW85WeZyi1Tqrnybd3702/19s9LcXqVblnV/33OQs6aqyzP1Di2cchf bbaf5pPy/I3EEZlf1wpnCR1wnV0QGn9f4e2t3jNT30R0VP+3rjnaO7spSt1b6eXhZ5PnMH4T 2XpF/6xjq7MSS3FGoqEWc1FxIgBfJqttigIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday, February 24, 2016 02:01:59 PM Caesar Wang wrote: > Hi, > > Thanks Dinh & Alexander for the intergration testing. > > --- > > @Dinh, > > Can you test it again with the patch[0]? > > patch[0]: > https://patchwork.kernel.org/patch/8398511/ This fixes the problem for me (tested on Samsung Exynos4412 SoC based Trats2 board). You may add: Tested-by: Bartlomiej Zolnierkiewicz to your patch. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > - > Caesar > 在 2016年02月23日 23:14, Dinh Nguyen 写道: > > Hi, > > > > Sorry that I couldn't get to this sooner. > > > > On 02/18/2016 10:07 AM, Alexander Kochetkov wrote: > >> Hello! > >> > >> Bartlomiej, could you please tell what uart driver is used on Samsung > >> Exynos4412? > >> Dinh, could you please tell what uart driver is used on SoCFPGA? > >> > > SoCFPGA is using the 8250_dw.c uart driver. > > > >> Could you make two test? > >> > >> 1) Checkout tree at commit 848e9776fee4 "dmaengine: pl330: support > >> burst mode for > >> dev-to-mem and mem-to-dev transmit", make it buildable and see is it > >> works. In order to make in buildable remove bursts argument from the > >> line: > >> > >> if (*bursts == 1) > >> - return _bursts(pl330, dry_run, buf, pxs, 1); > >> + return _bursts(dry_run, buf, pxs, 1); > >> > > This case still fails for me. > > > >> 2) Checkout next-20160211 kernel tree and set src_maxburst and > >> dst_maxburst to 1 inside UART driver to see is it works? > >> > > This case works and the UART is able to operate in DMA mode. > > > > Dinh