public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Johan Hovold <johan@kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH v1 09/10] PM: sleep: Propagate power.set_active in dependency chains
Date: Tue, 11 Feb 2025 22:21:23 +0100	[thread overview]
Message-ID: <47028492.fMDQidcC6G@rjwysocki.net> (raw)
In-Reply-To: <2314745.iZASKD2KPV@rjwysocki.net>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

After preparing pm_runtime_force_resume() for dealing with devices
having power.set_active set, make the core propagate that flag in
dependency chains, so that subordinate device are resumed along with
the ones that they depend on, but take exceptions into account.

Namely, do not set power.set_active for devices that have never had
runtime PM enabled, for parents that have power.ignore_children set and
for suppliers coming from device links with DL_FLAG_PM_RUNTIME unset.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/base/power/main.c |   25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -1189,18 +1189,31 @@
 	return PMSG_ON;
 }
 
+static void dpm_cond_set_active(struct device *dev, bool cond)
+{
+	if (cond && !pm_runtime_no_support(dev))
+		dev->power.set_active = true;
+}
+
 static void dpm_superior_set_must_resume(struct device *dev)
 {
+	bool set_active = dev->power.set_active;
 	struct device_link *link;
 	int idx;
 
-	if (dev->parent)
+	if (dev->parent) {
 		dev->parent->power.must_resume = true;
+		dpm_cond_set_active(dev->parent, set_active &&
+				    !dev->parent->power.ignore_children);
+	}
 
 	idx = device_links_read_lock();
 
-	list_for_each_entry_rcu_locked(link, &dev->links.suppliers, c_node)
+	list_for_each_entry_rcu_locked(link, &dev->links.suppliers, c_node) {
 		link->supplier->power.must_resume = true;
+		dpm_cond_set_active(link->supplier, set_active &&
+				    (link->flags & DL_FLAG_PM_RUNTIME));
+	}
 
 	device_links_read_unlock(idx);
 }
@@ -1277,13 +1290,7 @@
 		dev->power.must_resume = true;
 
 	if (dev->power.must_resume) {
-		if (dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND) &&
-		    !pm_runtime_no_support(dev)) {
-			dev->power.set_active = true;
-			if (dev->parent && !dev->parent->power.ignore_children &&
-			    !pm_runtime_no_support(dev->parent))
-				dev->parent->power.set_active = true;
-		}
+		dpm_cond_set_active(dev, dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND));
 		dpm_superior_set_must_resume(dev);
 	}
 




  parent reply	other threads:[~2025-02-11 21:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 21:01 [PATCH v1 00/10] PM: Make the core and pm_runtime_force_suspend/resume() agree more Rafael J. Wysocki
2025-02-11 21:02 ` [PATCH v1 01/10] PM: runtime: Introduce pm_runtime_no_support() Rafael J. Wysocki
2025-02-11 21:03 ` [PATCH v1 02/10] PM: sleep: core: Use pm_runtime_no_support() during set_active updates Rafael J. Wysocki
2025-02-11 21:05 ` [PATCH v1 03/10] PM: runtime: Use pm_runtime_no_support() in pm_runtime_force_suspend() Rafael J. Wysocki
2025-02-11 21:07 ` [PATCH v1 04/10] PM: runtime: Drop status check from pm_runtime_force_resume() Rafael J. Wysocki
2025-02-11 21:09 ` [PATCH v1 05/10] PM: runtime: Do not enable wakeup IRQs during system resume Rafael J. Wysocki
2025-02-11 21:10 ` [PATCH v1 06/10] PM: sleep: Adjust check before setting power.must_resume Rafael J. Wysocki
2025-02-11 21:11 ` [PATCH v1 07/10] PM: sleep: Clear the power.set_active upfront Rafael J. Wysocki
2025-02-11 21:19 ` [PATCH v1 08/10] PM: sleep: Make pm_runtime_force_resume() look at power.set_active Rafael J. Wysocki
2025-02-11 21:21 ` Rafael J. Wysocki [this message]
2025-02-11 21:25 ` [PATCH v1 10/10] PM: runtime: Discover the lack of runtime PM support Rafael J. Wysocki
2025-02-12 11:14   ` Rafael J. Wysocki
2025-02-12  9:12 ` [PATCH v1 00/10] PM: Make the core and pm_runtime_force_suspend/resume() agree more Ulf Hansson
2025-02-12 10:59   ` Rafael J. Wysocki
2025-02-12 11:33     ` Rafael J. Wysocki
2025-02-12 11:36       ` Rafael J. Wysocki
2025-02-12 15:14       ` Ulf Hansson
2025-02-12 17:05         ` Rafael J. Wysocki
2025-02-12 19:04           ` Rafael J. Wysocki
2025-02-13 13:37             ` Ulf Hansson
2025-02-13 20:42               ` Rafael J. Wysocki
2025-02-13 13:10           ` Ulf Hansson
2025-02-13 20:17             ` Rafael J. Wysocki
2025-02-14  9:55               ` Ulf Hansson
2025-02-15 12:32                 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47028492.fMDQidcC6G@rjwysocki.net \
    --to=rjw@rjwysocki.net \
    --cc=johan@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=stern@rowland.harvard.edu \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox