Re: [PATCH 5/5] lguest: loading bzImage directly

H. Peter Anvin
2007-11-24T22:15:26Z

Kjartan Maraas wrote:
> to., 04.10.2007 kl. 10.02 +1000, skrev Rusty Russell:
>> On Wed, 2007-10-03 at 10:37 +0100, Chris Malley wrote:
>>> Hi guys
>>>
>>> Would it not be clearer to #include <asm/bootparam.h> and use
>>> the relevant named members of struct setup_header / struct boot_params
>>> rather than the hard-coded values 0x202, 0x1F1, 0x214 ?
>> Yes, but unfortunately bootparam.h wasn't designed to be included from
>> userspace.
>>
> [snip]
>
> This change seems to have broken build of the battstat applet in
> gnome-applets or rather the included apmlib in there. Intended?
>
> Any pointers on how to adapt the code in case it was?
>

Perhaps you could actually give some detail how it broke the code?!

-hpa