Re: [PATCH 5/5] lguest: loading bzImage directly

H. Peter Anvin
2007-10-03T17:13:20Z

Chris Malley wrote:
> Hi guys
>
> Would it not be clearer to #include <asm/bootparam.h> and use
> the relevant named members of struct setup_header / struct boot_params
> rather than the hard-coded values 0x202, 0x1F1, 0x214 ?
>

Yes, please. I have a patch in -mm which already does that across the
kernel.

-hpa