From: "H. Peter Anvin" <hpa@zytor.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Chris Malley <mail@chrismalley.co.uk>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>, lguest <lguest@ozlabs.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Vivek Goyal <vgoyal@in.ibm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 5/5] lguest: loading bzImage directly
Date: Wed, 03 Oct 2007 17:26:57 -0700 [thread overview]
Message-ID: <47043351.2010708@zytor.com> (raw)
In-Reply-To: <1191456175.8268.6.camel@localhost.localdomain>
Rusty Russell wrote:
> On Wed, 2007-10-03 at 10:37 +0100, Chris Malley wrote:
>> Hi guys
>>
>> Would it not be clearer to #include <asm/bootparam.h> and use
>> the relevant named members of struct setup_header / struct boot_params
>> rather than the hard-coded values 0x202, 0x1F1, 0x214 ?
>
> Yes, but unfortunately bootparam.h wasn't designed to be included from
> userspace.
>
> The patch would look like this, but it makes me wonder if it'd be better
> to put all these user-exposed types in bootparam.h and have the other
> headers include them. hpa?
>
I don't have a strong preference either way, but I think what you have
here is fine.
-hpa
next prev parent reply other threads:[~2007-10-04 0:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 23:34 [PATCH 0/5] Boot protocol changes Rusty Russell
2007-10-02 23:35 ` [PATCH 1/5] update boot spec to 2.07 Rusty Russell
2007-10-02 23:35 ` [PATCH 2/5] add WEAK() for creating weak asm labels Rusty Russell
2007-10-02 23:36 ` [PATCH 3/5] i386: paravirt boot sequence Rusty Russell
2007-10-02 23:39 ` [PATCH 4/5] Revert lguest magic and use hook in head.S Rusty Russell
2007-10-02 23:40 ` [PATCH 5/5] lguest: loading bzImage directly Rusty Russell
2007-10-03 9:37 ` Chris Malley
2007-10-03 17:12 ` H. Peter Anvin
2007-10-04 0:02 ` Rusty Russell
2007-10-04 0:26 ` H. Peter Anvin [this message]
2007-11-24 21:54 ` Kjartan Maraas
2007-11-24 22:14 ` H. Peter Anvin
2007-11-25 12:32 ` Kjartan Maraas
2007-10-30 6:38 ` [PATCH 1/5] update boot spec to 2.07 rae l
2007-10-02 23:44 ` [PATCH 0/5] Boot protocol changes H. Peter Anvin
2007-10-02 23:46 ` Jeremy Fitzhardinge
2007-10-02 23:53 ` H. Peter Anvin
2007-10-02 23:56 ` Jeremy Fitzhardinge
2007-10-03 0:43 ` H. Peter Anvin
2007-10-03 0:46 ` H. Peter Anvin
2007-10-03 0:58 ` Jeremy Fitzhardinge
2007-10-03 1:03 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47043351.2010708@zytor.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ebiederm@xmission.com \
--cc=jeremy@goop.org \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@chrismalley.co.uk \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox