From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758897AbXJDJLR (ORCPT ); Thu, 4 Oct 2007 05:11:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753360AbXJDJLD (ORCPT ); Thu, 4 Oct 2007 05:11:03 -0400 Received: from sacred.ru ([62.205.161.221]:47554 "EHLO sacred.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509AbXJDJLB (ORCPT ); Thu, 4 Oct 2007 05:11:01 -0400 Message-ID: <4704AA39.5030208@openvz.org> Date: Thu, 04 Oct 2007 12:54:17 +0400 From: Pavel Emelyanov User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Matt Mackall CC: Andrew Morton , Sukadev Bhattiprolu , Linux Kernel Mailing List , devel@openvz.org Subject: Re: [PATCH 2/3] Prepare pid_nr() etc functions to work with not-NULL pids References: <4703A44F.9020402@openvz.org> <4703A53B.9090804@openvz.org> <20071003164258.GS19691@waste.org> In-Reply-To: <20071003164258.GS19691@waste.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-3.0 (sacred.ru [62.205.161.221]); Thu, 04 Oct 2007 12:56:45 +0400 (MSD) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Matt Mackall wrote: > On Wed, Oct 03, 2007 at 06:20:43PM +0400, Pavel Emelyanov wrote: >> Just make the __pid_nr() etc functions that expect the argument >> to always be not NULL. >> >> Signed-off-by: Pavel Emelyanov > >> static inline pid_t pid_nr(struct pid *pid) >> { >> pid_t nr = 0; >> if (pid) >> - nr = pid->numbers[0].nr; >> + nr = __pid_nr(pid); >> return nr; >> } > > Is there a patch that removes these inlines? Otherwise this looks good > to me. Not yet. Some of are uninlined already, but others are not. I'd like to make some testing before uninline them. > -- > Mathematics is the supreme nostalgia of our time. >