From: aissur0002@gmail.com
To: Fedor Pchelkin <aissur0002@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
Eric Biggers <ebiggers@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] file: Fix file descriptor leak in copy_fd_bitmaps()
Date: Tue, 29 Mar 2022 23:44:54 +0300 [thread overview]
Message-ID: <4705670.GXAFRqVoOG@fedor-zhuzhzhalka67> (raw)
In-Reply-To: <CAHk-=wh2Ao+OgnWSxHsJodXiLwtaUndXSkuhh9yKnA3iXyBLEA@mail.gmail.com>
> Btw, do you have a pointer to the syzbot report? I see the repro and
> the crashlog you attached, but it would be good to have that pointer
> to the syzbot original too.
>
> Or did you just do this by running syzkaller yourself and there is no
> external report?
Alexey V. Khoroshilov (<khoroshilov@ispras.ru>) will soon answer about
the syzbot original, I suppose. Personally, I possess only Crashlog and
repro.c file which I ran on a local machine and I don't know whether
there is an external report.
As for the solution you proposed, I agree with it: definitely the problem
was caused by an incorrect alignment of max_fds. Frankly speaking, I
didn't know that
> sane_fdtable_size() really should never return a value that
> isn't BITS_PER_LONG aligned
because there is no explicit alignment of max_fds value in the code as
I can see.
next prev parent reply other threads:[~2022-03-29 20:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 11:40 [PATCH 4/4] file: Fix file descriptor leak in copy_fd_bitmaps() Fedor Pchelkin
2022-03-26 14:17 ` Alexey Khoroshilov
2022-03-26 22:15 ` Linus Torvalds
2022-03-26 22:37 ` Linus Torvalds
2022-03-27 21:54 ` aissur0002
2022-03-27 22:21 ` Linus Torvalds
2022-03-29 10:23 ` Christian Brauner
2022-03-29 14:40 ` Christian Brauner
2022-03-29 21:28 ` Linus Torvalds
2022-03-29 20:44 ` aissur0002 [this message]
2022-03-29 21:02 ` Linus Torvalds
2022-03-29 22:18 ` Linus Torvalds
2022-03-29 22:23 ` Linus Torvalds
2022-03-30 7:47 ` Christian Brauner
2022-03-30 5:21 ` Jason A. Donenfeld
2022-03-30 6:08 ` Linus Torvalds
2022-03-30 6:21 ` Jason A. Donenfeld
2022-03-30 6:28 ` Linus Torvalds
2022-03-30 6:43 ` Linus Torvalds
2022-03-29 23:02 ` Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4705670.GXAFRqVoOG@fedor-zhuzhzhalka67 \
--to=aissur0002@gmail.com \
--cc=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox