From: Bernardo Innocenti <bernie@codewiz.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jordan Crouse <jordan.crouse@amd.com>,
Andres Solomon <dilinger@queued.net>,
OLPC Development <devel@laptop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup
Date: Fri, 05 Oct 2007 14:38:24 -0400 [thread overview]
Message-ID: <470684A0.2040604@codewiz.org> (raw)
In-Reply-To: <20071005131530.GC7397@ucw.cz>
On 10/05/2007 09:15 AM, Pavel Machek wrote:
>> This patch merges the fb_powerup and fb_powerdown hooks in a single
>> operation fb_power with an additional "state" parameter ranging
>> from 0 (running) to 3 (poweroff).
>
> No, please don't. Having int with 0/3 being valid specifying what to
> do is evil.
>
> enum is less evil, but what's wrong about having 3 functions?
Later on, the patch was reworked by Jordan Crouse to use
the fb_blank hook instead, which already has enough states.
So the fb_powerup/fb_powerdown hooks, which were not yet
upstream anyway, died off in the process.
--
\___/
|___| Bernardo Innocenti - http://www.codewiz.org/
\___\ One Laptop Per Child - http://www.laptop.org/
prev parent reply other threads:[~2007-10-05 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 23:11 [PATCH] GEODE: decouple sleep/resume from powerdown/powerup Bernardo Innocenti
2007-10-05 13:15 ` Pavel Machek
2007-10-05 18:38 ` Bernardo Innocenti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470684A0.2040604@codewiz.org \
--to=bernie@codewiz.org \
--cc=devel@laptop.org \
--cc=dilinger@queued.net \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox