From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: schwab@suse.de, rpjday@mindspring.com, bbpetkov@yahoo.de,
linux-kernel@vger.kernel.org, muli@il.ibm.com,
satyam@infradead.org, amitkale@netxen.com,
achim_leubner@adaptec.com
Subject: Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1
Date: Fri, 05 Oct 2007 15:32:45 -0700 [thread overview]
Message-ID: <4706BB8D.9070408@goop.org> (raw)
In-Reply-To: <20071005152450.a7652b75.akpm@linux-foundation.org>
Andrew Morton wrote:
> Well yes, but DMA_BIT_MASK(0) invokes undefined behaviour, generates a
> compiler warning and evaluates to 0xffffffffffffffff (with my setup).
>
> That won't be a problem in practice, but it is strictly wrong and doesn't set
> a good exmaple for the children ;)
>
It's interesting that it doesn't seem to be possible to define this
without invoking some undefined behaviour. But a device that supports 0
bits of DMA address probably isn't terribly concerned about this - it's
certainly better than making 64 bit masks warty.
J
next prev parent reply other threads:[~2007-10-05 22:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 19:46 [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1 Borislav Petkov
2007-09-19 15:03 ` Satyam Sharma
2007-10-05 19:47 ` Andrew Morton
2007-10-05 20:43 ` Jeremy Fitzhardinge
2007-10-05 21:00 ` Andrew Morton
2007-10-05 21:03 ` Robert P. J. Day
2007-10-05 21:23 ` Jeremy Fitzhardinge
2007-10-06 7:54 ` Borislav Petkov
2007-10-05 21:24 ` Andreas Schwab
2007-10-05 21:28 ` Jeremy Fitzhardinge
2007-10-05 22:24 ` Andrew Morton
2007-10-05 22:32 ` Jeremy Fitzhardinge [this message]
2007-10-06 8:37 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4706BB8D.9070408@goop.org \
--to=jeremy@goop.org \
--cc=achim_leubner@adaptec.com \
--cc=akpm@linux-foundation.org \
--cc=amitkale@netxen.com \
--cc=bbpetkov@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=rpjday@mindspring.com \
--cc=satyam@infradead.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox