From: Jiri Slaby <jirislaby@gmail.com>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
airlied@linux.ie, arashi@sacredchao.net
Subject: Re: Revert "intel_agp: fix stolen mem range on G33"
Date: Sat, 06 Oct 2007 12:41:21 +0200 [thread overview]
Message-ID: <47076651.8020801@gmail.com> (raw)
In-Reply-To: <20071006054234.GC14767@fattire.cabal.ca>
On 10/06/2007 07:42 AM, Kyle McMartin wrote:
> This reverts commit f443675affe3f16dd428e46f0f7fd3f4d703eeab, which
> breaks horribly if you aren't running an unreleased xf86-video-intel
> driver out of git.
I guess, this will break my graphics, no?
http://lkml.org/lkml/2007/9/20/447
> Conflicts:
>
> drivers/char/agp/intel-agp.c
>
> Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
> ---
>
> drivers/char/agp/intel-agp.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
> index a5d0e95..141ca17 100644
> --- a/drivers/char/agp/intel-agp.c
> +++ b/drivers/char/agp/intel-agp.c
> @@ -506,11 +506,6 @@ static void intel_i830_init_gtt_entries(void)
> break;
> }
> } else {
> - /* G33's GTT stolen memory is separate from gfx data
> - * stolen memory.
> - */
> - if (IS_G33)
> - size = 0;
> switch (gmch_ctrl & I855_GMCH_GMS_MASK) {
> case I855_GMCH_GMS_STOLEN_1M:
> gtt_entries = MB(1) - KB(size);
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University
next prev parent reply other threads:[~2007-10-06 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-06 0:20 G33 graphics broken after 2.6.23-rc6 Matthew Reppert
2007-10-06 4:42 ` Kyle McMartin
2007-10-06 5:34 ` Kyle McMartin
2007-10-06 5:42 ` Revert "intel_agp: fix stolen mem range on G33" Kyle McMartin
2007-10-06 10:41 ` Jiri Slaby [this message]
2007-10-06 15:59 ` Linus Torvalds
2007-10-06 19:29 ` Keith Packard
2007-10-07 10:05 ` Jiri Slaby
2007-10-07 12:17 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47076651.8020801@gmail.com \
--to=jirislaby@gmail.com \
--cc=airlied@linux.ie \
--cc=arashi@sacredchao.net \
--cc=dri-devel@lists.sourceforge.net \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox