From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754456AbXJGOj4 (ORCPT ); Sun, 7 Oct 2007 10:39:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752957AbXJGOjq (ORCPT ); Sun, 7 Oct 2007 10:39:46 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:54414 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752902AbXJGOjp (ORCPT ); Sun, 7 Oct 2007 10:39:45 -0400 Message-ID: <4708EFA6.20902@garzik.org> Date: Sun, 07 Oct 2007 10:39:34 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.5 (X11/20070727) MIME-Version: 1.0 To: netdev@vger.kernel.org, Ayaz Abdulla CC: LKML , Andrew Morton , Yinghai Lu , Ingo Molnar Subject: Re: [PATCH 3/5] forcedeth: process TX completions using NAPI References: <20071006151250.GA17020@havoc.gtf.org> <20071006151438.GC17488@havoc.gtf.org> In-Reply-To: <20071006151438.GC17488@havoc.gtf.org> Content-Type: multipart/mixed; boundary="------------010706080902040703000001" X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------010706080902040703000001 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Jeff Garzik wrote: > commit 57cbfacc00d69be2ba02b65d1021442273b76263 > Author: Jeff Garzik > Date: Fri Oct 5 23:25:56 2007 -0400 > > [netdrvr] forcedeth: process TX completions using NAPI > > Signed-off-by: Jeff Garzik > > drivers/net/forcedeth.c | 143 +++++++++++++++++++++++++++--------------------- > 1 file changed, 83 insertions(+), 60 deletions(-) The attached patch fixes an obvious bug. Once applied, TX NAPI actually works :) --------------010706080902040703000001 Content-Type: text/plain; name="patch.fe3" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch.fe3" diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c index 1c236e6..e25c05e 100644 --- a/drivers/net/forcedeth.c +++ b/drivers/net/forcedeth.c @@ -3059,7 +3059,7 @@ static irqreturn_t nv_nic_irq_tx(int foo, void *data) static int nv_napi_tx_poll(struct napi_struct *napi, int budget) { - struct fe_priv *np = container_of(napi, struct fe_priv, napi); + struct fe_priv *np = container_of(napi, struct fe_priv, tx_napi); struct net_device *dev = np->dev; u8 __iomem *base = get_hwbase(dev); unsigned long flags; --------------010706080902040703000001--