Re: RFC: reviewer's statement of oversight

Jonathan Corbet
2007-10-08T19:09:04Z

Al Viro <viro@ftp.linux.org.uk> wrote:

> > A patch which is not "worthwhile" is also not "appropriate". Mere
> > correctness in a mathematical sense is not enough as technical review
> > criterion.
>
> Yes, but there's also such thing as "worthwhile removal".

Good point. So the text should probably say "worthwhile change" rather
than "worthwhile addition." I do believe that thinking about whether
the change as a whole is a desirable thing is an important part of the
review process.

jon