From: George Beshers <gbeshers@gmail.com>
To: torvalds@osdl.org, tony.luck@intel.com, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] Cleanup misleading IA64 ACPI error message
Date: Wed, 10 Oct 2007 08:15:43 -0400 [thread overview]
Message-ID: <470CC26F.6070301@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: MADT.patch --]
[-- Type: text/x-patch, Size: 1190 bytes --]
On Altix (sn2) machines the "Error parsing MADT" message is
misleading because the lack of IOSAPIC entries is expected.
Since I am sure someone will ask, I have been told that
the chance of this changing anytime soon is close to nil.
Signed-off-by: George Beshers <gbeshers@sgi.com>
---
acpi.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff -purN linux-2.6.23/arch/ia64/kernel/acpi.c linux-2.6.23.b/arch/ia64/kernel/acpi.c
--- linux-2.6.23/arch/ia64/kernel/acpi.c 2007-10-09 16:31:38.000000000 -0400
+++ linux-2.6.23.b/arch/ia64/kernel/acpi.c 2007-10-09 21:43:29.283569798 -0400
@@ -678,9 +678,14 @@ int __init acpi_boot_init(void)
/* I/O APIC */
if (acpi_table_parse_madt
- (ACPI_MADT_TYPE_IO_SAPIC, acpi_parse_iosapic, NR_IOSAPICS) < 1)
- printk(KERN_ERR PREFIX
- "Error parsing MADT - no IOSAPIC entries\n");
+ (ACPI_MADT_TYPE_IO_SAPIC, acpi_parse_iosapic, NR_IOSAPICS) < 1) {
+ if (ia64_platform_is("sn2"))
+ printk(KERN_NOTICE
+ "SGI/SN machines do not have IOSAPIC entries\n");
+ else
+ printk(KERN_ERR PREFIX
+ "Error parsing MADT - no IOSAPIC entries\n");
+ }
/* System-Level Interrupt Routing */
reply other threads:[~2007-10-10 12:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470CC26F.6070301@gmail.com \
--to=gbeshers@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox