From: "hinko.kocevar@cetrtapot.si" <hinko.kocevar@cetrtapot.si>
To: irda-users@lists.sourceforge.net
Cc: Samuel Ortiz <samuel@sortiz.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] irlmp_unregister_link needs to free lsaps hashbin
Date: Fri, 12 Oct 2007 14:56:27 +0200 [thread overview]
Message-ID: <470F6EFB.6010704@cetrtapot.si> (raw)
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
Hi,
While testing the mcs7780 based IrDA USB dongle I've stumbled upon
memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in
irlmp_register_link and should probably be freed in irlmp_unregister_link().
Signed-off-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
Best regards,
Hinko
----
[-- Attachment #2: irlmp-delete-lsaps-hashbin.diff --]
[-- Type: text/plain, Size: 355 bytes --]
--- linux-2.6.23/net/irda/irlmp.c.orig 2007-10-12 14:05:17.000000000 +0200
+++ linux-2.6.23/net/irda/irlmp.c 2007-10-12 14:05:41.000000000 +0200
@@ -353,6 +353,7 @@ void irlmp_unregister_link(__u32 saddr)
/* Final cleanup */
del_timer(&link->idle_timer);
link->magic = 0;
+ hashbin_delete(link->lsaps, (FREE_FUNC) kfree);
kfree(link);
}
}
next reply other threads:[~2007-10-12 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 12:56 hinko.kocevar [this message]
2007-10-13 1:03 ` [irda-users] [PATCH] irlmp_unregister_link needs to free lsaps hashbin Samuel Ortiz
2007-10-15 7:43 ` hinko.kocevar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470F6EFB.6010704@cetrtapot.si \
--to=hinko.kocevar@cetrtapot.si \
--cc=irda-users@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox