public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [Patch]fixed: perf cannot show existing process callgraph symbol
@ 2010-02-05 17:02 austin_zhang
  2010-02-08 15:57 ` [tip:perf/core] perf record: Fix " tip-bot for austin_zhang@linux.intel.com
  0 siblings, 1 reply; 2+ messages in thread
From: austin_zhang @ 2010-02-05 17:02 UTC (permalink / raw)
  To: a.p.zijlstra, paulus, mingo, acme; +Cc: linux-kernel, austin.zhang

When 'perf record -g' a existing process, even with debuginfo
packages, still cannnot get symbol from 'perf report'.

try:
perf record -g -p `pidof xxx` -f
perf report

    68.26%    :1181           b74870f2  [.] 0x000000b74870f2
              |
              |--32.09%-- 0xb73b5b44
              |          0xb7487102
              |          0xb748a4e2
              |          0xb748633d
              |          0xb73b41cd
              |          0xb73b4467
              |          0xb747d531

The reason is: for existing process, in __cmd_record(),
the pid is 0 rather than the existing process id.

Signed-off-by: Austin Zhang <austin_zhang@linux.intel.com>
---
 tools/perf/builtin-record.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 2654253..1d62d2a 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -552,7 +552,7 @@ static int __cmd_record(int argc, const char **argv)
 	}

 	if (!system_wide && profile_cpu == -1)
-		event__synthesize_thread(pid, process_synthesized_event,
+		event__synthesize_thread(target_pid, process_synthesized_event,
 					 session);
 	else
 		event__synthesize_threads(process_synthesized_event, session);
-- 
1.6.1.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:perf/core] perf record: Fix existing process callgraph symbol
  2010-02-05 17:02 [Patch]fixed: perf cannot show existing process callgraph symbol austin_zhang
@ 2010-02-08 15:57 ` tip-bot for austin_zhang@linux.intel.com
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for austin_zhang@linux.intel.com @ 2010-02-08 15:57 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, acme, paulus, hpa, mingo, a.p.zijlstra, efault,
	fweisbec, tglx, austin_zhang, mingo

Commit-ID:  f7e7ee36757f68778700cde1aaed89e1d23e59fd
Gitweb:     http://git.kernel.org/tip/f7e7ee36757f68778700cde1aaed89e1d23e59fd
Author:     austin_zhang@linux.intel.com <austin_zhang@linux.intel.com>
AuthorDate: Fri, 5 Feb 2010 09:02:42 -0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 8 Feb 2010 16:55:52 +0100

perf record: Fix existing process callgraph symbol

When 'perf record -g' a existing process, even with debuginfo
packages, still cannnot get symbol from 'perf report'.

try:

 perf record -g -p `pidof xxx` -f
 perf report

    68.26%    :1181           b74870f2  [.] 0x000000b74870f2
              |
              |--32.09%-- 0xb73b5b44
              |          0xb7487102
              |          0xb748a4e2
              |          0xb748633d
              |          0xb73b41cd
              |          0xb73b4467
              |          0xb747d531

The reason is: for existing process, in __cmd_record(),
the pid is 0 rather than the existing process id.

Signed-off-by: Austin Zhang <austin_zhang@linux.intel.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <4710.10.255.24.35.1265389362.squirrel@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 tools/perf/builtin-record.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 3ad599b..771533c 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -570,7 +570,7 @@ static int __cmd_record(int argc, const char **argv)
 	}
 
 	if (!system_wide && profile_cpu == -1)
-		event__synthesize_thread(pid, process_synthesized_event,
+		event__synthesize_thread(target_pid, process_synthesized_event,
 					 session);
 	else
 		event__synthesize_threads(process_synthesized_event, session);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-08 15:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-05 17:02 [Patch]fixed: perf cannot show existing process callgraph symbol austin_zhang
2010-02-08 15:57 ` [tip:perf/core] perf record: Fix " tip-bot for austin_zhang@linux.intel.com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox