public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] V4L: possible leak in em28xx_init_isoc
@ 2007-10-15 15:59 Florin Malita
  0 siblings, 0 replies; only message in thread
From: Florin Malita @ 2007-10-15 15:59 UTC (permalink / raw)
  To: mchehab; +Cc: Linux Kernel Mailing List

Coverity (CID 1929) spotted the following: if a transfer buffer 
allocation fails, the last allocated urb is leaked (it hasn't been 
stored in dev->urb[] yet so em28xx_uninit_isoc misses it). The patch 
also includes a small typo fix.

Signed-off-by: Florin Malita <fmalita@gmail.com>
---

 drivers/media/video/em28xx/em28xx-core.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c
index d3282ec..d56484f 100644
--- a/drivers/media/video/em28xx/em28xx-core.c
+++ b/drivers/media/video/em28xx/em28xx-core.c
@@ -648,7 +648,7 @@ void em28xx_uninit_isoc(struct em28xx *dev)
  */
 int em28xx_init_isoc(struct em28xx *dev)
 {
-	/* change interface to 3 which allowes the biggest packet sizes */
+	/* change interface to 3 which allows the biggest packet sizes */
 	int i, errCode;
 	const int sb_size = EM28XX_NUM_PACKETS * dev->max_pkt_size;
 
@@ -673,6 +673,7 @@ int em28xx_init_isoc(struct em28xx *dev)
 					("unable to allocate %i bytes for transfer buffer %i\n",
 					 sb_size, i);
 			em28xx_uninit_isoc(dev);
+			usb_free_urb(urb);
 			return -ENOMEM;
 		}
 		memset(dev->transfer_buffer[i], 0, sb_size);


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-10-15 15:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 15:59 [PATCH] V4L: possible leak in em28xx_init_isoc Florin Malita

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox