From: Jeff Garzik <jeff@garzik.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Ingo Molnar <mingo@elte.hu>, David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
shemminger@linux-foundation.org
Subject: Re: [patch] forcedeth: fix the NAPI poll function
Date: Mon, 15 Oct 2007 18:41:14 -0400 [thread overview]
Message-ID: <4713EC8A.5010607@garzik.org> (raw)
In-Reply-To: <4713EC59.4010106@pobox.com>
Jeff Garzik wrote:
>> --- linux.orig/drivers/net/forcedeth.c
>> +++ linux/drivers/net/forcedeth.c
>> @@ -2274,7 +2274,7 @@ static int nv_rx_process(struct net_devi
>>
>> while((np->get_rx.orig != np->put_rx.orig) &&
>> !((flags = le32_to_cpu(np->get_rx.orig->flaglen)) &
>> NV_RX_AVAIL) &&
>> - (rx_processed_cnt++ < limit)) {
>> + (++rx_processed_cnt < limit)) {
>>
>> dprintk(KERN_DEBUG "%s: nv_rx_process: flags 0x%x.\n",
>> dev->name, flags);
>> @@ -2412,7 +2412,7 @@ static int nv_rx_process_optimized(struc
>>
>> while((np->get_rx.ex != np->put_rx.ex) &&
>> !((flags = le32_to_cpu(np->get_rx.ex->flaglen)) &
>> NV_RX2_AVAIL) &&
>> - (rx_processed_cnt++ < limit)) {
>> + (++rx_processed_cnt < limit)) {
Though it wasn't clear, that's an ACK
I'll push the patch if nobody else beats me to it.
next prev parent reply other threads:[~2007-10-15 22:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 11:24 WARNING: at net/core/dev.c:2161 net_rx_action() Ingo Molnar
2007-10-15 11:27 ` Ingo Molnar
2007-10-15 16:18 ` Ingo Molnar
2007-10-15 19:57 ` David Miller
2007-10-15 22:03 ` Ingo Molnar
2007-10-15 22:07 ` Ingo Molnar
2007-10-15 22:21 ` David Miller
2007-10-15 22:30 ` [patch] forcedeth: fix the NAPI poll function Ingo Molnar
2007-10-15 22:39 ` David Miller
2007-10-15 22:40 ` Jeff Garzik
2007-10-15 22:41 ` Jeff Garzik [this message]
2007-10-16 5:42 ` Ingo Molnar
2007-10-16 5:47 ` Jeff Garzik
2007-10-16 6:40 ` Ingo Molnar
2007-10-16 7:17 ` Jeff Garzik
2007-10-16 7:49 ` Ingo Molnar
2007-10-16 16:52 ` Jeff Garzik
2007-10-16 21:20 ` Jeff Garzik
2007-10-17 7:25 ` Ingo Molnar
2007-10-17 10:18 ` [patch] forcedeth: fix the NAPI poll function, take #2 Ingo Molnar
2007-10-18 0:21 ` Jeff Garzik
2007-10-15 22:18 ` WARNING: at net/core/dev.c:2161 net_rx_action() David Miller
2007-10-15 22:20 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713EC8A.5010607@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shemminger@linux-foundation.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox