public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Greg KH <greg@kroah.com>,
	pcihpd-discuss@lists.sourceforge.net,
	Andrew Morton <akpm@linux-foundation.org>,
	Theodore Tso <tytso@mit.edu>
Subject: [PATCH 0/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
Date: Tue, 16 Oct 2007 21:53:24 -0400	[thread overview]
Message-ID: <47156B14.2080608@rtr.ca> (raw)
In-Reply-To: <471533AF.60100@rtr.ca>

Original single patch is now broken out into tiny pieces for easier review.

Also, valuable feedback from Ted has been incorporated,
to avoid any possible side effects on regular use of
the PCIe hotplug stuff (when used without pciehp_force=1 mod parm).

* * *

Fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks
in conjunction with the modparam of pciehp_force=1.

The PCIe Hotplug driver has two shortcomings when used on Dell notebooks
which lack ACPI BIOS support for PCIe hotplug:

1. The driver does not recognise cards that were inserted prior
to the driver being modprobe'd.

2. The driver stops functioning after a suspend/resume (RAM) cycle,
and needs to be rmmod'd and modprobe'd to get it working again.

This patch series addresses those issues, resulting in a completely
functional PCIe Hotplug driver for Dell notebooks, and probably others
as well, which may lack ACPI BIOS support for this.

There are four patches in this series:

	01_pciehp_cosmetic_fixes.patch
		-- cosmetic fixes, mostly to keep checkpatch.pl happy

	02_pciehp_handle_preinserted_card.patch
		-- fixes problem number 1 (above).

	03_pciehp_split_pcie_init.patch
		-- preparation for the resume patch.

	04_pciehp_resume.patch
		-- fixes problem number 2 (above).

diffstat summary for 01_pciehp_cosmetic_fixes.patch only:
 drivers/pci/hotplug/pciehp_core.c |    6 -
 drivers/pci/hotplug/pciehp_ctrl.c |    2
 drivers/pci/hotplug/pciehp_hpc.c  |  119 ++++++++++++++--------------
 3 files changed, 65 insertions(+), 62 deletions(-)

diffstat summary for the other three patches combined:
 drivers/pci/hotplug/pciehp.h      |    3
 drivers/pci/hotplug/pciehp_core.c |   21 ++-
 drivers/pci/hotplug/pciehp_ctrl.c |    2
 drivers/pci/hotplug/pciehp_hpc.c  |  194 ++++++++++++++++------------
 4 files changed, 134 insertions(+), 86 deletions(-)

Cheers
--
Mark Lord <mlord@pobox.com>

  parent reply	other threads:[~2007-10-17  1:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16 13:46 PCIe Hotplug: NFG unless I boot with card already inserted Mark Lord
2007-10-16 15:21 ` Mark Lord
2007-10-16 15:46   ` Kristen Carlson Accardi
2007-10-16 18:39     ` Mark Lord
2007-10-16 18:43       ` Kristen Carlson Accardi
2007-10-16 18:57         ` Mark Lord
2007-10-16 18:59           ` Mark Lord
2007-10-16 19:31             ` Mark Lord
2007-10-16 19:51               ` Kristen Carlson Accardi
2007-10-16 20:07               ` Kristen Carlson Accardi
2007-10-16 20:39                 ` Mark Lord
2007-10-16 21:01                   ` Kristen Carlson Accardi
2007-10-16 22:33                     ` Theodore Tso
2007-10-16 21:41                   ` [Pcihpd-discuss] " Greg KH
2007-10-16 21:57                     ` [PATCH] Fix PCIe hotplug for Dell notebook ExpressCard slots Mark Lord
2007-10-16 22:03                       ` Greg KH
2007-10-16 22:19                         ` Mark Lord
2007-10-16 22:41                         ` [Pcihpd-discuss] " Kristen Carlson Accardi
2007-10-16 22:04                       ` Kristen Carlson Accardi
2007-10-16 22:17                         ` Mark Lord
2007-10-17  1:53                       ` Mark Lord [this message]
2007-10-17  1:54                         ` [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2) Mark Lord
2007-10-17  1:54                           ` [PATCH 2/4] " Mark Lord
2007-10-17  1:55                             ` [PATCH 3/4] " Mark Lord
2007-10-17  1:55                               ` [PATCH 4/4] " Mark Lord
2007-10-18  0:01                                 ` Kristen Carlson Accardi
2007-10-18  2:28                                   ` Mark Lord
2007-10-17  3:31                             ` [Pcihpd-discuss] [PATCH 2/4] " Matthew Wilcox
2007-10-17 23:54                             ` Kristen Carlson Accardi
2007-10-18  2:25                               ` Mark Lord
2007-10-17  3:29                           ` [Pcihpd-discuss] [PATCH 1/4] " Matthew Wilcox
2007-10-17 13:09                             ` Mark Lord
2007-10-17 14:02                               ` Matthew Wilcox
2007-10-17 14:33                                 ` Mark Lord
2007-10-17 22:02                         ` [PATCH 0/4] " Andrew Morton
2007-10-17 22:59                           ` Mark Lord
2007-10-17 23:25                             ` Andrew Morton
2007-10-16 20:29       ` PCIe Hotplug: NFG unless I boot with card already inserted Kristen Carlson Accardi
2007-10-16 20:41         ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47156B14.2080608@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pcihpd-discuss@lists.sourceforge.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox