Re: [Pcihpd-discuss] [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)

Mark Lord
2007-10-17T14:33:51Z

Matthew Wilcox wrote:
> On Wed, Oct 17, 2007 at 09:09:24AM -0400, Mark Lord wrote:
>
>> ..
>>>> - temp_word = (temp_word & ~intr_enable) | intr_enable;
>>>> + temp_word = (temp_word & ~intr_enable) | intr_enable;
>>> *boggle*
>> Dig out your text editor, and notice the excess whitespace at the end of the line,
>> along with similar stuff on most other lines in this patch.
>
> You, however, did clip the important line.
>
>>> temp_word |= intr_enable;
>
> which is what I was saying the above is equivalent to.

Gag-me. That *is* bad. But the PCIe folks seem to be extra sensitive
about the code, so I'm trying to change as little as possible here.
That line was just the result of doing this in vim: :%s/[ ]*$//g

I agree there's a lot of funny looking code in there,
but that's not what this particular patch series is about.
You could submit a follow-up patch to repair that stuff, if you like.

Mmm.. I wonder how clever gcc is with a line like that.. ? ;)

Cheers!