Re: [Pcihpd-discuss] [PATCH 2/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)

Matthew Wilcox
2007-10-17T03:31:32Z

On Tue, Oct 16, 2007 at 09:54:42PM -0400, Mark Lord wrote:
> if (rc)
> goto err_out_free_ctrl_slot;
> - }
> + } else if (pciehp_force)
> + pciehp_enable_slot(t_slot);
>

I find the construct if () { ... } else ...; to be a bit jarring. How
about adding the extra braces?

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."