Re: [PATCH 4/4] fix not-and/or errors

Al Viro
2007-10-17T14:36:13Z

On Wed, Oct 17, 2007 at 03:55:29PM +0200, Roel Kluin wrote:
> if(!x & y) should either be if(!(x & y)) or if(!x && y)
> I made changes as seemed appropriate, but please review
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c
> index 5cd3cad..7229319 100644
> --- a/arch/arm/mach-pxa/mfp.c
> +++ b/arch/arm/mach-pxa/mfp.c
> @@ -199,7 +199,7 @@ void pxa3xx_mfp_set_edge(int mfp, int edge)
>
> mfpr_val &= ~MFPR_EDGE_MASK;
> mfpr_val |= (edge & 0x3u) << MFPR_ERE_OFFSET;
> - mfpr_val |= (!edge & 0x1) << MFPR_EC_OFFSET;
> + mfpr_val |= (!(edge & 0x1)) << MFPR_EC_OFFSET;
>
> mfpr_writel(mfpr_off, mfpr_val);
> mfpr_sync();

ACK

> diff --git a/arch/sh/drivers/dma/dma-sh.c b/arch/sh/drivers/dma/dma-sh.c
> index 958bac1..e8f9c85 100644
> --- a/arch/sh/drivers/dma/dma-sh.c
> +++ b/arch/sh/drivers/dma/dma-sh.c
> @@ -89,7 +89,7 @@ static irqreturn_t dma_tei(int irq, void *dev_id)
>
> static int sh_dmac_request_dma(struct dma_channel *chan)
> {
> - if (unlikely(!chan->flags & DMA_TEI_CAPABLE))
> + if (unlikely(!(chan->flags & DMA_TEI_CAPABLE)))
> return 0;
>
> return request_irq(get_dmte_irq(chan->chan), dma_tei,

ACK

> --- a/drivers/acpi/asus_acpi.c
> +++ b/drivers/acpi/asus_acpi.c
> @@ -596,7 +596,7 @@ write_led(const char __user * buffer, unsigned long count,
> (led_out) ? (hotk->status | ledmask) : (hotk->status & ~ledmask);
>
> if (invert) /* invert target value */
> - led_out = !led_out & 0x1;
> + led_out = !(led_out & 0x1);

No, simply !led_out

> + if ((!battery->flags.battery_present_prev && acpi_battery_present(battery))
> + || (battery->flags.battery_present_prev && !acpi_battery_present(battery))) {

ITYM != and you've missed another one like that in the same file.

The rest is covered by earlier patches