Re: [bug] ata subsystem related crash with latest -git

Jens Axboe
2007-10-18T10:18:26Z

On Thu, Oct 18 2007, Jens Axboe wrote:
> On Thu, Oct 18 2007, Ingo Molnar wrote:
> >
> > * Jens Axboe <jens.axboe@oracle.com> wrote:
> >
> > > > Of course, this doesn't explain why ata_sg_is_last() was broken, but
> > > > since it's working _and_ slightly more efficient, I don't really
> > > > care :)
> > >
> > > Tomo and I agreed to kill sg_last() a few days ago anyways, so this is
> > > perfectly fine with me.
> >
> > it would still be nice to figure out exactly why it was broken.
>
> It would always be nice. For this case I don't think it's very
> interesting, if we pursue the improved sg iteration setup.

BTW, I think it's pretty clear that ata_sg_is_last() is broken. It's
likely a one-off in the n_iter test.

--
Jens Axboe