* Fix guest time accounting going faster than user time accounting
@ 2007-10-18 17:41 Christian Borntraeger
2007-10-18 19:13 ` Laurent Vivier
0 siblings, 1 reply; 2+ messages in thread
From: Christian Borntraeger @ 2007-10-18 17:41 UTC (permalink / raw)
To: Avi Kivity; +Cc: Laurent Vivier, kvm-devel, linux-kernel
Seems I overlooked this type while reviewing Laurents patch.
cputime_add already adds, dont do it twice.
Avi. This should go to Linus before 2.6.24.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
fs/proc/array.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.23/fs/proc/array.c
===================================================================
--- linux-2.6.23.orig/fs/proc/array.c
+++ linux-2.6.23/fs/proc/array.c
@@ -446,7 +446,7 @@ static int do_task_stat(struct task_stru
maj_flt += sig->maj_flt;
utime = cputime_add(utime, sig->utime);
stime = cputime_add(stime, sig->stime);
- gtime += cputime_add(gtime, sig->gtime);
+ gtime = cputime_add(gtime, sig->gtime);
}
sid = signal_session(sig);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix guest time accounting going faster than user time accounting
2007-10-18 17:41 Fix guest time accounting going faster than user time accounting Christian Borntraeger
@ 2007-10-18 19:13 ` Laurent Vivier
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Vivier @ 2007-10-18 19:13 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: Avi Kivity, kvm-devel, linux-kernel
Acked-by: Laurent Vivier <Laurent.Vivier@bull.net>
Christian Borntraeger a écrit :
> Seems I overlooked this type while reviewing Laurents patch.
> cputime_add already adds, dont do it twice.
>
> Avi. This should go to Linus before 2.6.24.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> ---
> fs/proc/array.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23/fs/proc/array.c
> ===================================================================
> --- linux-2.6.23.orig/fs/proc/array.c
> +++ linux-2.6.23/fs/proc/array.c
> @@ -446,7 +446,7 @@ static int do_task_stat(struct task_stru
> maj_flt += sig->maj_flt;
> utime = cputime_add(utime, sig->utime);
> stime = cputime_add(stime, sig->stime);
> - gtime += cputime_add(gtime, sig->gtime);
> + gtime = cputime_add(gtime, sig->gtime);
> }
>
> sid = signal_session(sig);
>
--
---------------- Laurent.Vivier@bull.net -----------------
"Given enough eyeballs, all bugs are shallow" E. S. Raymond
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-18 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-18 17:41 Fix guest time accounting going faster than user time accounting Christian Borntraeger
2007-10-18 19:13 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox