* Re: libata crash [not found] <20071018164745.GD10674@kernel.dk> @ 2007-10-18 19:28 ` Ingo Molnar 2007-10-18 19:32 ` Jens Axboe 0 siblings, 1 reply; 8+ messages in thread From: Ingo Molnar @ 2007-10-18 19:28 UTC (permalink / raw) To: Jens Axboe Cc: linux-kernel, Linus Torvalds, Jeff Garzik, Alan Cox, David S. Miller, Andrew Morton, Mark Lord * Jens Axboe <jens.axboe@oracle.com> wrote: > Hi Ingo, > > Can you try this rolled up patch against current -git and see if it > works for you? update: booted up a couple of times with your patch (with DEBUG_PAGEALLOC enabled) and it's working all fine, no crashes. So i think you nailed it! Ingo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libata crash 2007-10-18 19:28 ` libata crash Ingo Molnar @ 2007-10-18 19:32 ` Jens Axboe 2007-10-18 19:59 ` Ingo Molnar 0 siblings, 1 reply; 8+ messages in thread From: Jens Axboe @ 2007-10-18 19:32 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Linus Torvalds, Jeff Garzik, Alan Cox, David S. Miller, Andrew Morton, Mark Lord On Thu, Oct 18 2007, Ingo Molnar wrote: > > * Jens Axboe <jens.axboe@oracle.com> wrote: > > > Hi Ingo, > > > > Can you try this rolled up patch against current -git and see if it > > works for you? > > update: booted up a couple of times with your patch (with > DEBUG_PAGEALLOC enabled) and it's working all fine, no crashes. So i > think you nailed it! Awesome, thanks a lot for testing it Ingo! I'll see if I can spend some time tonight chopping the patch into digestable pieces, unfortunately I'll be away the next three days. And it would be nice to get this thing merged asap. -- Jens Axboe ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libata crash 2007-10-18 19:32 ` Jens Axboe @ 2007-10-18 19:59 ` Ingo Molnar 2007-10-18 20:41 ` Jens Axboe 0 siblings, 1 reply; 8+ messages in thread From: Ingo Molnar @ 2007-10-18 19:59 UTC (permalink / raw) To: Jens Axboe Cc: linux-kernel, Linus Torvalds, Jeff Garzik, Alan Cox, David S. Miller, Andrew Morton, Mark Lord * Jens Axboe <jens.axboe@oracle.com> wrote: > I'll see if I can spend some time tonight chopping the patch into > digestable pieces, unfortunately I'll be away the next three days. And > it would be nice to get this thing merged asap. and make sure it builds: drivers/scsi/fd_mcs.c: In function 'fd_mcs_intr': drivers/scsi/fd_mcs.c:976: error: 'struct scatterlist' has no member named 'page' drivers/scsi/fd_mcs.c:1009: error: 'struct scatterlist' has no member named 'page' drivers/scsi/fd_mcs.c: In function 'fd_mcs_queue': drivers/scsi/fd_mcs.c:1112: error: 'struct scatterlist' has no member named 'page' drivers/scsi/in2000.c: In function 'in2000_queuecommand': drivers/scsi/in2000.c:375: error: 'struct scatterlist' has no member named 'page' drivers/scsi/in2000.c: In function 'transfer_bytes': drivers/scsi/in2000.c:767: error: 'struct scatterlist' has no member named 'page' ;-) Ingo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libata crash 2007-10-18 19:59 ` Ingo Molnar @ 2007-10-18 20:41 ` Jens Axboe 2007-10-18 20:52 ` Jeff Garzik 2007-10-19 6:48 ` Ingo Molnar 0 siblings, 2 replies; 8+ messages in thread From: Jens Axboe @ 2007-10-18 20:41 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Linus Torvalds, Jeff Garzik, Alan Cox, David S. Miller, Andrew Morton, Mark Lord On Thu, Oct 18 2007, Ingo Molnar wrote: > * Jens Axboe <jens.axboe@oracle.com> wrote: > > > I'll see if I can spend some time tonight chopping the patch into > > digestable pieces, unfortunately I'll be away the next three days. And > > it would be nice to get this thing merged asap. > > and make sure it builds: > > drivers/scsi/fd_mcs.c: In function 'fd_mcs_intr': > drivers/scsi/fd_mcs.c:976: error: 'struct scatterlist' has no member named 'page' > drivers/scsi/fd_mcs.c:1009: error: 'struct scatterlist' has no member named 'page' > drivers/scsi/fd_mcs.c: In function 'fd_mcs_queue': > drivers/scsi/fd_mcs.c:1112: error: 'struct scatterlist' has no member named 'page' > drivers/scsi/in2000.c: In function 'in2000_queuecommand': > drivers/scsi/in2000.c:375: error: 'struct scatterlist' has no member named 'page' > drivers/scsi/in2000.c: In function 'transfer_bytes': > drivers/scsi/in2000.c:767: error: 'struct scatterlist' has no member named 'page' Oops, wonder why they were missed in the allyes/modconfig. Fixed now, thanks! -- Jens Axboe ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libata crash 2007-10-18 20:41 ` Jens Axboe @ 2007-10-18 20:52 ` Jeff Garzik 2007-10-19 7:05 ` Jan Dittmer 2007-10-19 6:48 ` Ingo Molnar 1 sibling, 1 reply; 8+ messages in thread From: Jeff Garzik @ 2007-10-18 20:52 UTC (permalink / raw) To: Jens Axboe Cc: Ingo Molnar, linux-kernel, Linus Torvalds, Alan Cox, David S. Miller, Andrew Morton, Mark Lord Jens Axboe wrote: > On Thu, Oct 18 2007, Ingo Molnar wrote: >> * Jens Axboe <jens.axboe@oracle.com> wrote: >> >>> I'll see if I can spend some time tonight chopping the patch into >>> digestable pieces, unfortunately I'll be away the next three days. And >>> it would be nice to get this thing merged asap. >> and make sure it builds: >> >> drivers/scsi/fd_mcs.c: In function 'fd_mcs_intr': >> drivers/scsi/fd_mcs.c:976: error: 'struct scatterlist' has no member named 'page' >> drivers/scsi/fd_mcs.c:1009: error: 'struct scatterlist' has no member named 'page' >> drivers/scsi/fd_mcs.c: In function 'fd_mcs_queue': >> drivers/scsi/fd_mcs.c:1112: error: 'struct scatterlist' has no member named 'page' >> drivers/scsi/in2000.c: In function 'in2000_queuecommand': >> drivers/scsi/in2000.c:375: error: 'struct scatterlist' has no member named 'page' >> drivers/scsi/in2000.c: In function 'transfer_bytes': >> drivers/scsi/in2000.c:767: error: 'struct scatterlist' has no member named 'page' > > Oops, wonder why they were missed in the allyes/modconfig. Fixed now, > thanks! Building on x86-64, I'm betting? :) I fell victim to the same thing a few days ago, missing some compile breakage that only appeared with make ARCH=i386 allmodconfig && make ARCH=i386 -sj9 Though am I alone in dreaming of a kernel.org service that would permit all-arch build testing of a git URL? Regards, Jeff ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libata crash 2007-10-18 20:52 ` Jeff Garzik @ 2007-10-19 7:05 ` Jan Dittmer 2007-10-19 10:12 ` Denys Vlasenko 0 siblings, 1 reply; 8+ messages in thread From: Jan Dittmer @ 2007-10-19 7:05 UTC (permalink / raw) To: Jeff Garzik Cc: Jens Axboe, Ingo Molnar, linux-kernel, Linus Torvalds, Alan Cox, David S. Miller, Andrew Morton, Mark Lord Jeff Garzik wrote: > Building on x86-64, I'm betting? :) > > I fell victim to the same thing a few days ago, missing some compile > breakage that only appeared with > > make ARCH=i386 allmodconfig && make ARCH=i386 -sj9 > > Though am I alone in dreaming of a kernel.org service that would permit > all-arch build testing of a git URL? I could add that to the service at http://l4x.org/k/ if there is sufficient (>1) interest. Jan ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libata crash 2007-10-19 7:05 ` Jan Dittmer @ 2007-10-19 10:12 ` Denys Vlasenko 0 siblings, 0 replies; 8+ messages in thread From: Denys Vlasenko @ 2007-10-19 10:12 UTC (permalink / raw) To: Jan Dittmer Cc: Jeff Garzik, Jens Axboe, Ingo Molnar, linux-kernel, Linus Torvalds, Alan Cox, David S. Miller, Andrew Morton, Mark Lord On Friday 19 October 2007 08:05, Jan Dittmer wrote: > Jeff Garzik wrote: > > Building on x86-64, I'm betting? :) > > > > I fell victim to the same thing a few days ago, missing some compile > > breakage that only appeared with > > > > make ARCH=i386 allmodconfig && make ARCH=i386 -sj9 > > > > Though am I alone in dreaming of a kernel.org service that would permit > > all-arch build testing of a git URL? > > I could add that to the service at http://l4x.org/k/ if there is > sufficient (>1) interest. Wow. When you click on Ok/Fail, you get a build log. One part of it (make oldconfig output) is not usable much, verbatim .config would be more useful. But this is a minor nitpicking. Overall looks awesome. -- vda ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libata crash 2007-10-18 20:41 ` Jens Axboe 2007-10-18 20:52 ` Jeff Garzik @ 2007-10-19 6:48 ` Ingo Molnar 1 sibling, 0 replies; 8+ messages in thread From: Ingo Molnar @ 2007-10-19 6:48 UTC (permalink / raw) To: Jens Axboe Cc: linux-kernel, Linus Torvalds, Jeff Garzik, Alan Cox, David S. Miller, Andrew Morton, Mark Lord * Jens Axboe <jens.axboe@oracle.com> wrote: > > and make sure it builds: > > > > drivers/scsi/fd_mcs.c: In function 'fd_mcs_intr': > > drivers/scsi/fd_mcs.c:976: error: 'struct scatterlist' has no member named 'page' > > drivers/scsi/fd_mcs.c:1009: error: 'struct scatterlist' has no member named 'page' > > drivers/scsi/fd_mcs.c: In function 'fd_mcs_queue': > > drivers/scsi/fd_mcs.c:1112: error: 'struct scatterlist' has no member named 'page' > > drivers/scsi/in2000.c: In function 'in2000_queuecommand': > > drivers/scsi/in2000.c:375: error: 'struct scatterlist' has no member named 'page' > > drivers/scsi/in2000.c: In function 'transfer_bytes': > > drivers/scsi/in2000.c:767: error: 'struct scatterlist' has no member named 'page' > > Oops, wonder why they were missed in the allyes/modconfig. Fixed now, > thanks! where can i pick the latest sg patchset up from? These build failures are ruining my make randconfig build tests :) Ingo ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2007-10-19 10:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20071018164745.GD10674@kernel.dk>
2007-10-18 19:28 ` libata crash Ingo Molnar
2007-10-18 19:32 ` Jens Axboe
2007-10-18 19:59 ` Ingo Molnar
2007-10-18 20:41 ` Jens Axboe
2007-10-18 20:52 ` Jeff Garzik
2007-10-19 7:05 ` Jan Dittmer
2007-10-19 10:12 ` Denys Vlasenko
2007-10-19 6:48 ` Ingo Molnar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox