From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966759AbXJSHhf (ORCPT ); Fri, 19 Oct 2007 03:37:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763342AbXJSHhX (ORCPT ); Fri, 19 Oct 2007 03:37:23 -0400 Received: from sacred.ru ([62.205.161.221]:54014 "EHLO sacred.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761909AbXJSHhW (ORCPT ); Fri, 19 Oct 2007 03:37:22 -0400 Message-ID: <47185E9E.1030102@openvz.org> Date: Fri, 19 Oct 2007 11:37:02 +0400 From: Pavel Emelyanov User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: David Miller , olof@lixom.net CC: netdev@vger.kernel.org, devel@openvz.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone() References: <4715D9D2.8070102@openvz.org> <20071017.212302.68039057.davem@davemloft.net> <20071019022947.GA29560@lixom.net> <20071018.215521.28810637.davem@davemloft.net> In-Reply-To: <20071018.215521.28810637.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-3.0 (sacred.ru [62.205.161.221]); Fri, 19 Oct 2007 11:37:05 +0400 (MSD) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > From: Olof Johansson > Date: Thu, 18 Oct 2007 21:29:47 -0500 > >> So, looks like rcu_dereference() returned NULL. I don't know the >> filter code at all, but it seems like it might be a valid case? >> sk_detach_filter() seems to handle a NULL sk_filter, at least. >> >> >> So, this needs review by someone who knows the filter, but it fixes the >> problem for me: Yes. The NULL filter is a valid case, when there are no filters attached at all. So this fix is correct. Thanks, Olof. Sorry, Dave :( >> >> Signed-off-by: Olof Johansson Acked-by: Pavel Emelyanov > I've applied this for now to my net-2.6 tree, thanks Olof > for tracking this down. > > Pavel please take a look at this and let me know if it should > fixed in some other way. > > Thanks! >