public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/9] irq-remove: driver non-trivial
Date: Fri, 19 Oct 2007 14:36:08 -0400	[thread overview]
Message-ID: <4718F918.8050904@garzik.org> (raw)
In-Reply-To: <m1hcknge5y.fsf@ebiederm.dsl.xmission.com>

Eric W. Biederman wrote:
> [snip] Found issues and ran out of review bandwidth.

thanks for the comments!  I'll work through these.

There are definitely plenty of open issues I haven't yet tackled in the 
driver area, as you are seeing.  As you noted, a lot of these are with 
drivers doing weird things like calling their own interrupt function 
with (-1, NULL) or (0, NULL), which triggers some magic "I'm polling" 
behavior.


>>  	}
>>  __out:
>>  	spin_unlock(&mts->lock);
>> +
>> +	return IRQ_HANDLED;
> 
> Missing parport code change, see below.

those two parport changes were bogus, and actually got fixed up in patch #9


  reply	other threads:[~2007-10-19 18:36 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19  7:54 [PATCH 0/9] Remove 'irq' argument from all irq handlers Jeff Garzik
2007-10-19  7:55 ` [PATCH 1/9] irq-remove: core Jeff Garzik
2007-10-19 17:27   ` Eric W. Biederman
2007-10-19 17:48     ` Jeff Garzik
2007-10-19 18:04   ` Eric W. Biederman
2007-10-19 18:21     ` Jeff Garzik
2007-10-19 19:50       ` Eric W. Biederman
2007-10-19 19:58         ` Jeff Garzik
2007-10-19 23:13           ` Eric W. Biederman
2007-10-19 23:46             ` Jeff Garzik
2007-10-19 23:53             ` Jeff Garzik
2007-10-19  7:55 ` [PATCH 2/9] irq-remove: arch non-trivial Jeff Garzik
2007-10-19 16:54   ` Jeremy Fitzhardinge
2007-10-19 17:31     ` Jeff Garzik
2007-10-19 17:50     ` Jeff Garzik
2007-10-19 17:11   ` Eric W. Biederman
2007-10-19 17:16     ` Jeff Garzik
2007-10-19 19:38       ` Eric W. Biederman
2007-10-19  7:56 ` [PATCH 3/9] irq-remove: arch trivial Jeff Garzik
2007-10-19  7:56 ` [PATCH 4/9] irq-remove: driver non-trivial Jeff Garzik
2007-10-19 18:19   ` Eric W. Biederman
2007-10-19 18:36     ` Jeff Garzik [this message]
2007-10-19  7:57 ` [PATCH 5/9] irq-remove: net driver trivial Jeff Garzik
2007-10-19  7:57 ` [PATCH 6/9] irq-remove: sound " Jeff Garzik
2007-10-19  7:58 ` [PATCH 7/9] irq-remove: scsi " Jeff Garzik
2007-10-19 13:00   ` Salyzyn, Mark
2007-10-26 21:35     ` Andrew Morton
2007-10-26 21:47       ` Jeff Garzik
2007-10-26 23:50         ` Arjan van de Ven
2007-10-27  0:12           ` Jeff Garzik
2007-10-27  0:16             ` Arjan van de Ven
2007-10-27  0:37               ` Jeff Garzik
2007-10-27  5:31                 ` Arjan van de Ven
2007-10-27  7:06                   ` Jeff Garzik
2007-10-27  7:46                     ` Eric W. Biederman
2007-10-27 14:17                       ` Arjan van de Ven
2007-10-19  7:58 ` [PATCH 8/9] irq-remove: " Jeff Garzik
2007-10-19  7:59 ` [PATCH 9/9] irq-remove: misc fixes and cleanups Jeff Garzik
2007-10-19 14:53 ` [PATCH 0/9] Remove 'irq' argument from all irq handlers Thomas Gleixner
2007-10-19 18:38   ` Eric W. Biederman
2007-10-19 18:57     ` Jeff Garzik
2007-10-19 19:02       ` Jeff Garzik
2007-10-19 19:07     ` Ingo Molnar
2007-10-19 19:35       ` Eric W. Biederman
2007-10-19 19:41         ` Thomas Gleixner
2007-10-19 19:55           ` Jeff Garzik
2007-10-19 18:45 ` Mark Gross
2007-10-20  6:07 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4718F918.8050904@garzik.org \
    --to=jeff@garzik.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox