From: Larry Finger <larry.finger@lwfinger.net>
To: Jiri Kosina <jikos@jikos.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb-devel@lists.sourceforge.net
Subject: Re: Locking problem in usbserial with 2.6.23-git 5a34417f
Date: Fri, 19 Oct 2007 17:19:21 -0500 [thread overview]
Message-ID: <47192D69.60203@lwfinger.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0710200001520.18815@twin.jikos.cz>
Jiri Kosina wrote:
> On Fri, 19 Oct 2007, Larry Finger wrote:
>
>> As I said earlier, the lock problem went away; however, I get the
>> following two kernel warnings:
>
> That's because I messed up the patch, sorry. The one below should work
> better.
>
>
>
> From: Jiri Kosina <jkosina@suse.cz>
>
> USB: usbserial - fix potential deadlock between write() and IRQ
>
> usb_serial_generic_write() doesn't disable interrupts when taking port->lock,
> and could therefore deadlock with usb_serial_generic_read_bulk_callback()
> being called from interrupt, taking the same lock. Fix it.
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
It does work better. With it, I was able to make a dial-up connection and send pings over it.
Larry
next prev parent reply other threads:[~2007-10-19 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 15:59 Locking problem in usbserial with 2.6.23-git 5a34417f Larry Finger
2007-10-19 21:06 ` Jiri Kosina
2007-10-19 21:29 ` Larry Finger
2007-10-19 21:36 ` Larry Finger
2007-10-19 22:05 ` Jiri Kosina
2007-10-19 22:19 ` Larry Finger [this message]
2007-10-20 5:59 ` [linux-usb-devel] " Greg KH
2007-10-24 21:37 ` patch usb-usbserial-fix-potential-deadlock-between-write-and-irq.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47192D69.60203@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=gregkh@suse.de \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox