public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Gabriel C <nix.or.die@googlemail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, Gabriel C <crazy@pimpmylinux.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: some kernel headers broken in current git ?
Date: Sat, 20 Oct 2007 21:29:33 -0700	[thread overview]
Message-ID: <471AD5AD.9030000@zytor.com> (raw)
In-Reply-To: <4719174A.7020004@googlemail.com>

Gabriel C wrote:
> Hi,
> 
> usually I'll wait for rc1 and test compile external module to see which are broken and what need fixing
> but while I need virtualbox for some tests I test compile it on current git and it failed badly.
> 
> Maybe something is missing from x86 merge ?
> 
> Here is what I get :
> 
> ...
> 
> /linux/memobj-r0drv-linux.c
> In file included from /lib/modules/2.6.23-g4fa4d23f-dirty/build/include/asm/atomic_32.h:265,
>                  from /lib/modules/2.6.23-g4fa4d23f-dirty/build/include/asm/atomic.h:2,
>                  from /lib/modules/2.6.23-g4fa4d23f-dirty/build/include/asm/spinlock_32.h:4,
>                  from /lib/modules/2.6.23-g4fa4d23f-dirty/build/include/asm/spinlock.h:2,
>                  from /lib/modules/2.6.23-g4fa4d23f-dirty/build/include/linux/spinlock.h:87,
>                  from /work/crazy/VBox/stable/virtualbox/src/VirtualBox-1.5.2_OSE/src/VBox/Runtime/r0drv/linux/the-linux-kernel.h:53,
>                  from /work/crazy/VBox/stable/virtualbox/src/VirtualBox-1.5.2_OSE/src/VBox/Runtime/r0drv/linux/alloc-r0drv-linux.c:22:
> /lib/modules/2.6.23-g4fa4d23f-dirty/build/include/asm-generic/atomic.h:23: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'atomic_long_t'

I have been unable to make heads or tails of the maze of twisty 
dependencies that VirtualBox wants, but the fact that it gets to line 23 
of <asm-generic/atomic.h> means it has gotten past:

     21  #if BITS_PER_LONG == 64
     22
     23  typedef atomic64_t atomic_long_t;

BITS_PER_LONG was originally set in <asm/types.h>:

     39  #ifdef CONFIG_X86_32
     40  # define BITS_PER_LONG 32
     41  #else
     42  # define BITS_PER_LONG 64
     43  #endif

The most obvious reason for failure is that the symbol CONFIG_X86_32 
isn't being defined where expected.  From that point on everything goes 
to hell.

Have you done "make oldconfig && make prepare" in your kernel tree since 
you last updated it?

	-hpa


  parent reply	other threads:[~2007-10-21  4:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 20:44 some kernel headers broken in current git ? Gabriel C
2007-10-19 21:08 ` Jiri Kosina
2007-10-19 21:19   ` Gabriel C
2007-10-19 22:23     ` Gabriel C
2007-10-19 22:49       ` Thomas Gleixner
2007-10-19 23:43         ` Gabriel C
2007-10-20  1:34           ` H. Peter Anvin
2007-10-21  4:29 ` H. Peter Anvin [this message]
2007-10-21 10:25   ` Gabriel C
2007-10-21 12:39     ` Gabriel C
2007-10-21 19:15       ` H. Peter Anvin
2007-10-21 20:02         ` Sam Ravnborg
2007-10-21 21:22           ` Gabriel C
2007-10-21 21:26             ` H. Peter Anvin
2007-10-21 21:56               ` Gabriel C
2007-10-21 20:10         ` Gabriel C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471AD5AD.9030000@zytor.com \
    --to=hpa@zytor.com \
    --cc=crazy@pimpmylinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nix.or.die@googlemail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox