* [PATCH] Fixing the warning in cgroup.c
@ 2007-10-21 17:30 Kamalesh Babulal
2007-10-21 17:55 ` Balbir Singh
2007-10-24 6:29 ` Andrew Morton
0 siblings, 2 replies; 3+ messages in thread
From: Kamalesh Babulal @ 2007-10-21 17:30 UTC (permalink / raw)
To: menage; +Cc: Andrew Morton, Balbir Singh, vatsa, Dhaval Giani, LKML
Hi,
Removing the unused variable root.
kernel/cgroup.c: In function ‘proc_cgroupstats_show’:
kernel/cgroup.c:2405: warning: unused variable ‘root’
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Index: linux-git/kernel/cgroup.c
===================================================================
--- linux-git.orig/kernel/cgroup.c 2007-10-21 08:49:15.000000000 +0530
+++ linux-git/kernel/cgroup.c 2007-10-21 22:24:13.000000000 +0530
@@ -2402,7 +2402,6 @@ struct file_operations proc_cgroup_opera
static int proc_cgroupstats_show(struct seq_file *m, void *v)
{
int i;
- struct cgroupfs_root *root;
seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");
mutex_lock(&cgroup_mutex);
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fixing the warning in cgroup.c
2007-10-21 17:30 [PATCH] Fixing the warning in cgroup.c Kamalesh Babulal
@ 2007-10-21 17:55 ` Balbir Singh
2007-10-24 6:29 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Balbir Singh @ 2007-10-21 17:55 UTC (permalink / raw)
To: Kamalesh Babulal; +Cc: menage, Andrew Morton, vatsa, Dhaval Giani, LKML
Kamalesh Babulal wrote:
> Hi,
>
> Removing the unused variable root.
>
> kernel/cgroup.c: In function ‘proc_cgroupstats_show’:
> kernel/cgroup.c:2405: warning: unused variable ‘root’
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>
> Index: linux-git/kernel/cgroup.c
> ===================================================================
> --- linux-git.orig/kernel/cgroup.c 2007-10-21 08:49:15.000000000 +0530
> +++ linux-git/kernel/cgroup.c 2007-10-21 22:24:13.000000000 +0530
> @@ -2402,7 +2402,6 @@ struct file_operations proc_cgroup_opera
> static int proc_cgroupstats_show(struct seq_file *m, void *v)
> {
> int i;
> - struct cgroupfs_root *root;
>
> seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");
> mutex_lock(&cgroup_mutex);
>
>
Looks good to me!
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fixing the warning in cgroup.c
2007-10-21 17:30 [PATCH] Fixing the warning in cgroup.c Kamalesh Babulal
2007-10-21 17:55 ` Balbir Singh
@ 2007-10-24 6:29 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2007-10-24 6:29 UTC (permalink / raw)
To: Kamalesh Babulal; +Cc: menage, Balbir Singh, vatsa, Dhaval Giani, LKML
On Sun, 21 Oct 2007 23:00:20 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> Removing the unused variable root.
>
> kernel/cgroup.c: In function ‘proc_cgroupstats_show’:
> kernel/cgroup.c:2405: warning: unused variable ‘root’
ERROR: Invalid UTF-8
#3:
kernel/cgroup.c: In function ‘proc_cgroupstats_show’:
ERROR: Invalid UTF-8
#4:
kernel/cgroup.c:2405: warning: unused variable ‘root’
total: 2 errors, 0 warnings, 7 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please use LANG=C so gcc doesn't do this.
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>
> Index: linux-git/kernel/cgroup.c
> ===================================================================
> --- linux-git.orig/kernel/cgroup.c 2007-10-21 08:49:15.000000000 +0530
> +++ linux-git/kernel/cgroup.c 2007-10-21 22:24:13.000000000 +0530
> @@ -2402,7 +2402,6 @@ struct file_operations proc_cgroup_opera
> static int proc_cgroupstats_show(struct seq_file *m, void *v)
> {
> int i;
> - struct cgroupfs_root *root;
>
> seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");
> mutex_lock(&cgroup_mutex);
your email client is converting tabs to spaces.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-24 6:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-21 17:30 [PATCH] Fixing the warning in cgroup.c Kamalesh Babulal
2007-10-21 17:55 ` Balbir Singh
2007-10-24 6:29 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox