From: Michael Krufky <mkrufky@linuxtv.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix CONFIG_TUNER_TEA5761=m
Date: Sun, 21 Oct 2007 23:33:05 -0400 [thread overview]
Message-ID: <471C19F1.8090505@linuxtv.org> (raw)
In-Reply-To: <20071022024755.GJ30533@stusta.de>
Adrian Bunk wrote:
> This patch fixes CONFIG_TUNER_TEA5761=m broken by
> commit ca805d57cf5ea7482ed3da28653f30621249ee45.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> drivers/media/video/tuner-core.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> 26336c30e76c37bda368a24b8b12978388a18cf3
> diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
> index 9484308..1795b78 100644
> --- a/drivers/media/video/tuner-core.c
> +++ b/drivers/media/video/tuner-core.c
> @@ -30,9 +30,7 @@
>
> /* standard i2c insmod options */
> static unsigned short normal_i2c[] = {
> -#ifdef CONFIG_TUNER_TEA5761
> 0x10,
> -#endif
>
^^^ I believe that we want to keep these #ifdef's above... The removals
below are fine.
> 0x42, 0x43, 0x4a, 0x4b, /* tda8290 */
> 0x60, 0x61, 0x62, 0x63, 0x64, 0x65, 0x66, 0x67,
> 0x68, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e, 0x6f,
> @@ -292,7 +290,6 @@ static void set_type(struct i2c_client *c, unsigned int type,
> }
> t->mode_mask = T_RADIO;
> break;
> -#ifdef CONFIG_TUNER_TEA5761
> case TUNER_TEA5761:
> if (tea5761_attach(&t->fe, t->i2c.adapter, t->i2c.addr) == NULL) {
> t->type = TUNER_ABSENT;
> @@ -301,7 +298,6 @@ static void set_type(struct i2c_client *c, unsigned int type,
> }
> t->mode_mask = T_RADIO;
> break;
> -#endif
> case TUNER_PHILIPS_FMD1216ME_MK3:
> buffer[0] = 0x0b;
> buffer[1] = 0xdc;
> @@ -594,7 +590,6 @@ static int tuner_attach(struct i2c_adapter *adap, int addr, int kind)
> /* autodetection code based on the i2c addr */
> if (!no_autodetect) {
> switch (addr) {
> -#ifdef CONFIG_TUNER_TEA5761
> case 0x10:
> if (tea5761_autodetection(t->i2c.adapter, t->i2c.addr) != EINVAL) {
> t->type = TUNER_TEA5761;
> @@ -606,7 +601,6 @@ static int tuner_attach(struct i2c_adapter *adap, int addr, int kind)
> goto register_client;
> }
> break;
> -#endif
> case 0x42:
> case 0x43:
> case 0x4a:
>
>
Regards,
Mike Krufky
next prev parent reply other threads:[~2007-10-22 3:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 2:47 [2.6 patch] fix CONFIG_TUNER_TEA5761=m Adrian Bunk
2007-10-22 3:33 ` Michael Krufky [this message]
2007-10-22 5:29 ` [v4l-dvb-maintainer] " Trent Piepho
2007-10-22 11:41 ` Michael Krufky
2007-10-22 20:31 ` Trent Piepho
2007-10-22 12:16 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471C19F1.8090505@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox