From: Richard Pearman <richard.pearman@intellect.com.au>
To: Greg KH <greg@kroah.com>, pberger@brimson.com, borchers@steinerpoint.com
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 001] USB: Error handling bug fix for serial_open()
Date: Mon, 22 Oct 2007 11:47:08 +0800 [thread overview]
Message-ID: <471C1D3C.1080801@intellect.com.au> (raw)
In-Reply-To: <20071008220821.GA31234@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
From: Richard Pearman <richard.pearman@intellect.com.au>
From: Greg Breen <greg.breen@intellect.com.au>
When an error occurs in serial_open() ensure that port->tty and
tty->driver_data are set to NULL, if previously assigned a value in the
function.
Signed-off-by: Richard S. Pearman <richard.pearman@intellect.com.au>
---
--- linux-2.6.17.1/drivers/usb/serial/usb-serial.c.orig Mon Oct 22
11:12:29 2007
+++ linux-2.6.17.1/drivers/usb/serial/usb-serial.c Mon Oct 22
11:12:23 2007
@@ -230,6 +230,8 @@ bailout_module_put:
module_put(serial->type->driver.owner);
bailout_mutex_unlock:
port->open_count = 0;
+ port->tty = NULL;
+ tty->driver_data = NULL;
mutex_unlock(&port->mutex);
bailout_kref_put:
kref_put(&serial->kref, destroy_serial);
[-- Attachment #2: richard.pearman.vcf --]
[-- Type: text/x-vcard, Size: 408 bytes --]
begin:vcard
fn:Richard Pearman
n:Pearman;Richard
org:Intellect Australia;Embedded Systems Team
adr:EIR Building, Technology Park, Bentley;;Suite 11 and 12, 1 Sarich Way;Perth;WA;6102;Australia
email;internet:richard.pearman@intellect.com.au
title:Senior embedded systems engineer
tel;work:+61 (08) 9472 2271
tel;fax:+61 (08) 9470 2584
x-mozilla-html:FALSE
url:http://www.intellect.be
version:2.1
end:vcard
next parent reply other threads:[~2007-10-22 3:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4709B59F.3020307@intellect.com.au>
[not found] ` <20071008220821.GA31234@kroah.com>
2007-10-22 3:47 ` Richard Pearman [this message]
2007-10-24 21:27 ` [PATCH 001] USB: Error handling bug fix for serial_open() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471C1D3C.1080801@intellect.com.au \
--to=richard.pearman@intellect.com.au \
--cc=borchers@steinerpoint.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pberger@brimson.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox