[PATCH 001] USB: Error handling bug fix for serial_open()

[PATCH 001] USB: Error handling bug fix for serial_open()

[Richard Pearman]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

From: Richard Pearman <richard.pearman@intellect.com.au>
From: Greg Breen <greg.breen@intellect.com.au>

When an error occurs in serial_open() ensure that port->tty and 
tty->driver_data are set  to NULL, if previously assigned a value in the 
function.

Signed-off-by: Richard S. Pearman <richard.pearman@intellect.com.au>
---
--- linux-2.6.17.1/drivers/usb/serial/usb-serial.c.orig    Mon Oct 22 
11:12:29 2007
+++ linux-2.6.17.1/drivers/usb/serial/usb-serial.c    Mon Oct 22 
11:12:23 2007
@@ -230,6 +230,8 @@ bailout_module_put:
     module_put(serial->type->driver.owner);
 bailout_mutex_unlock:
     port->open_count = 0;
+    port->tty = NULL;
+    tty->driver_data = NULL;   
     mutex_unlock(&port->mutex);
 bailout_kref_put:
     kref_put(&serial->kref, destroy_serial);

[-- Attachment #2: richard.pearman.vcf --]
[-- Type: text/x-vcard, Size: 408 bytes --]

begin:vcard
fn:Richard Pearman
n:Pearman;Richard
org:Intellect Australia;Embedded Systems Team
adr:EIR Building, Technology Park, Bentley;;Suite 11 and 12, 1 Sarich Way;Perth;WA;6102;Australia
email;internet:richard.pearman@intellect.com.au
title:Senior embedded systems  engineer
tel;work:+61 (08) 9472 2271
tel;fax:+61 (08) 9470 2584
x-mozilla-html:FALSE
url:http://www.intellect.be
version:2.1
end:vcard

Re: [PATCH 001] USB: Error handling bug fix for serial_open()

[Greg KH]

On Mon, Oct 22, 2007 at 11:47:08AM +0800, Richard Pearman wrote:
> From: Richard Pearman <richard.pearman@intellect.com.au>
> From: Greg Breen <greg.breen@intellect.com.au>
>
> When an error occurs in serial_open() ensure that port->tty and 
> tty->driver_data are set  to NULL, if previously assigned a value in the 
> function.
>
> Signed-off-by: Richard S. Pearman <richard.pearman@intellect.com.au>
> ---
> --- linux-2.6.17.1/drivers/usb/serial/usb-serial.c.orig    Mon Oct 22 

This has already been fixed in newer kernel versions.

Thanks for the patch though.

greg k-h