From: Michael Krufky <mkrufky@linuxtv.org>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: Adrian Bunk <bunk@kernel.org>,
v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [v4l-dvb-maintainer] [2.6 patch] fix CONFIG_TUNER_TEA5761=m
Date: Mon, 22 Oct 2007 07:41:18 -0400 [thread overview]
Message-ID: <471C8C5E.1070901@linuxtv.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0710212201060.16052@shell4.speakeasy.net>
Trent Piepho wrote:
> On Sun, 21 Oct 2007, Michael Krufky wrote:
>
>> Adrian Bunk wrote:
>>
>>> This patch fixes CONFIG_TUNER_TEA5761=m broken by
>>> commit ca805d57cf5ea7482ed3da28653f30621249ee45.
>>>
>>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>>>
>>> ---
>>>
>>> drivers/media/video/tuner-core.c | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> 26336c30e76c37bda368a24b8b12978388a18cf3
>>> diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
>>> index 9484308..1795b78 100644
>>> --- a/drivers/media/video/tuner-core.c
>>> +++ b/drivers/media/video/tuner-core.c
>>> @@ -30,9 +30,7 @@
>>>
>>> /* standard i2c insmod options */
>>> static unsigned short normal_i2c[] = {
>>> -#ifdef CONFIG_TUNER_TEA5761
>>> 0x10,
>>> -#endif
>>>
>>>
>> ^^^ I believe that we want to keep these #ifdef's above... The removals
>> below are fine.
>>
>
> Won't leaving in the call to tea5761_autodetection() when tea5761 is not
> compiled in result in an undefined symbol error?
>
It shouldn't -- See tea5761.h ... If the module is not selected, then a
stub will report that the driver was disabled by Kconfig.
> I think what we want to do put in the typical if(TEA5761 >= TUNER) include tea5761
> code in tuner logic that the rest of the selectable sub-driver use.
>
> #if defined(CONFIG_TUNER_TEA5761) || (defined(CONFIG_TUNER_TEA5761_MODULE) && defined(MODULE))
>
This is what I have in my tree here... ^^^ Isn't this already upstream
by now?
-Mike
next prev parent reply other threads:[~2007-10-22 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 2:47 [2.6 patch] fix CONFIG_TUNER_TEA5761=m Adrian Bunk
2007-10-22 3:33 ` Michael Krufky
2007-10-22 5:29 ` [v4l-dvb-maintainer] " Trent Piepho
2007-10-22 11:41 ` Michael Krufky [this message]
2007-10-22 20:31 ` Trent Piepho
2007-10-22 12:16 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471C8C5E.1070901@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox