From: Jiri Slaby <jirislaby@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: char/cyclades.c: inconsequent NULL checking
Date: Mon, 22 Oct 2007 21:06:20 +0200 [thread overview]
Message-ID: <471CF4AC.6060603@gmail.com> (raw)
In-Reply-To: <20071022024734.GI30533@stusta.de>
On 10/22/2007 04:47 AM, Adrian Bunk wrote:
> The Coverity checker spotted the following inconsequent NULL checking in
Where can one obtain such a checker?
> drivers/char/cyclades.c:
>
> <-- snip -->
>
> ...
> static void cyz_handle_tx(struct cyclades_port *info,
> struct BUF_CTRL __iomem *buf_ctrl)
> {
> struct cyclades_card *cinfo = info->card;
> struct tty_struct *tty = info->tty;
> ...
> if (tty == NULL)
> goto ztxdone;
> ...
> tty_wakeup(tty);
> ...
>
> <-- snip -->
patch on route, thanks,
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University
next prev parent reply other threads:[~2007-10-22 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 2:47 char/cyclades.c: inconsequent NULL checking Adrian Bunk
2007-10-22 19:06 ` Jiri Slaby [this message]
2007-10-22 19:12 ` Jiri Kosina
2007-10-22 19:42 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471CF4AC.6060603@gmail.com \
--to=jirislaby@gmail.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox