Re: [PATCH] e1000, e1000e valid-addr fixes

Jeff Garzik
2007-11-01T19:31:40Z

Stephen Hemminger wrote:
> How about:
>
> static int eth_validate_addr(const struct net_device *dev)
> {
> return is_valid_ether_addr(dev->dev_addr) ? 0 : -EINVAL;
> }

hmmm -- its a slow path, so I don't see the value of marking the
argument 'const' -- right now this implementation merely reads the
dev->dev_addr[], but that need not always be the case.

And I don't see the value of squashing everything onto one line, IMO the
current version is more readable.

Jeff