Re: [PATCH] e1000, e1000e valid-addr fixes

David Miller
2007-10-24T01:07:29Z

From: Jeff Garzik <jeff@garzik.org>
Date: Tue, 23 Oct 2007 21:03:36 -0400

> I'm wondering if there is a way to avoid adding
>
> if (!is_valid_ether_addr(dev->dev_addr))
> return -EINVAL;
>
> to every ethernet driver's ->open() hook.

The first idea I get is:

1) Create netdev->validate_dev_addr().

2) If it exists, invoke it before ->open(), abort
and return if any errors signaled.

etherdev init hooks up a function that does the above
check, which allows us to avoid editing every ethernet
driver

What do you think?