From: Jeff Garzik <jeff@garzik.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
matthew@wil.cx, arnd@arndb.de, ralf@linux-mips.org,
adobriyan@gmail.com, viro@ftp.linux.org.uk,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/2] irq_flags_t: intro and core annotations
Date: Tue, 23 Oct 2007 22:11:34 -0400 [thread overview]
Message-ID: <471EA9D6.9000004@garzik.org> (raw)
In-Reply-To: <E1IkAWI-0006vX-00@gondolin.me.apana.org.au>
Herbert Xu wrote:
> Jeff Garzik <jeff@garzik.org> wrote:
>> Let me add to the chorus of voices: I continually see two cases where
>> real bugs crop up:
>>
>> 1) hacker uses spin_lock_irq() in incorrect context (where it is not
>> safe to do a blind enable/disable)
>>
>> 2) hacker uses spin_lock_irq() correctly, but the surrounding code
>> changes, thus invalidating prior assumptions.
>>
>> I would even go so far as to support the drastic measure of deleting
>> spin_lock_irq().
>>
>> spin_lock_irqsave() generates fewer bugs, is more future-proof, and by
>> virtue of 'flags' permits architectures a bit more flexibility.
>
> Could we add a debug option that warned if spin_lock_irq is
> executed with IRQs turned off already?
Seems reasonable but perhaps arch-specific?
Also, I think someone (akpm?) mentioned an effort had been made before,
and run into some problems. I don't have details...
Jeff
next prev parent reply other threads:[~2007-10-24 2:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 23:55 [PATCH 1/2] irq_flags_t: intro and core annotations Alexey Dobriyan
2007-10-21 0:54 ` Al Viro
2007-10-21 9:30 ` Alexey Dobriyan
2007-10-22 15:29 ` Ralf Baechle
2007-10-22 18:21 ` Andrew Morton
2007-10-22 18:50 ` Geert Uytterhoeven
2007-10-22 19:10 ` Arnd Bergmann
2007-10-22 19:47 ` Matthew Wilcox
2007-10-22 19:56 ` Linus Torvalds
2007-10-22 20:02 ` Andrew Morton
2007-10-22 21:34 ` Arnd Bergmann
2007-10-22 21:46 ` Thomas Gleixner
2007-10-23 1:06 ` Arnd Bergmann
2007-10-23 1:28 ` USB HCD: avoid duplicate local_irq_disable() Arnd Bergmann
2007-10-23 4:01 ` [linux-usb-devel] " Alan Stern
2007-10-25 18:33 ` Greg KH
2007-10-27 19:14 ` Alan Stern
2007-10-22 20:47 ` [PATCH 1/2] irq_flags_t: intro and core annotations Jeff Garzik
2007-10-23 0:21 ` David Miller
2007-10-23 3:33 ` Herbert Xu
2007-10-24 2:11 ` Jeff Garzik [this message]
2007-10-24 8:55 ` Arnd Bergmann
2007-10-25 15:40 ` Jan Engelhardt
2007-10-27 20:24 ` Alexey Dobriyan
2007-10-27 20:32 ` Jan Engelhardt
2007-10-28 1:24 ` Herbert Xu
2007-10-27 19:20 ` Roman Zippel
2007-10-27 20:14 ` Alexey Dobriyan
2007-10-27 21:07 ` Peter Zijlstra
2007-10-27 21:22 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471EA9D6.9000004@garzik.org \
--to=jeff@garzik.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=ralf@linux-mips.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox