Re: [PATCH -mm 02/11] PCI: add device_dma_parameters support

FUJITA Tomonori
2007-10-24T13:41:57Z

On Wed, 24 Oct 2007 07:34:07 -0400
Jeff Garzik <jeff@garzik.org> wrote:

> FUJITA Tomonori wrote:
> > index 463a5a9..54edea2 100644
> > --- a/drivers/pci/probe.c
> > +++ b/drivers/pci/probe.c
> > @@ -985,8 +985,11 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus)
> >
> > set_dev_node(&dev->dev, pcibus_to_node(bus));
> > dev->dev.dma_mask = &dev->dma_mask;
> > + dev->dev.dma_parms = &dev->dma_parms;
> > dev->dev.coherent_dma_mask = 0xffffffffull;
> >
> > + pci_set_dma_max_seg_size(dev, 65536);
>
> this should check the return value of pci_set_dma_max_seg_size(), and do
> something useful.
>
> ACK everything else

Thanks.

I wasn't sure about what to do. Should pci_device_add fail in case of
pci_set_dma_max_seg_size failure or just should we print warning?