Re: [RFC - GIT pull] first step to get rid of x86_64 and i386 dirs

Yinghai Lu
2007-10-25T06:14:18Z

On 10/24/07, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Wed, 24 Oct 2007 23:30:52 +0200 Sam Ravnborg wrote:
>
> > Hi Ingo.
> >
> > This is first step in getting rid of the two directories.
> > I had to do some very minor modifications in common files
> > to let it work out - but nothing really hackish.
> >
> > If you & Thomas + hpa are OK with the changes they can be
> > pulled from:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/sam/x86.git
> >
> > As this is mostly renames I have attached a git -M diff only.
> >
> > The remaining stuff is Kconfig files.
> >
> > Before looking into these I am hoping someone could
> > step in and make the two Kconfig.debug
> > files 100% equal - because then I can fix the kconfig
> > stuff and finally kill the two directories.
>
> Uh, maybe I jumped too far. I merged the 2 x86 Kconfig.debug files
> into arch/x86/Kconfig.debug....
>
> ---
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Merge i386/Kconfig.debug and x86_64/Kconfig.debug into x86/Kconfig.debug,
> using "depends on X86_32" or X86_64 when needed.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/i386/Kconfig.debug | 88 ----------------------------------
> arch/x86/Kconfig.debug | 119 ++++++++++++++++++++++++++++++++++++++++++++++
> arch/x86_64/Kconfig.debug | 61 -----------------------
> 3 files changed, 119 insertions(+), 149 deletions(-)
>
> --- linux-2.6.24-rc1.orig/arch/i386/Kconfig.debug
> +++ /dev/null
> @@ -1,88 +0,0 @@
> -menu "Kernel hacking"
> -
> -config TRACE_IRQFLAGS_SUPPORT
> - bool
> - default y
> -
> -source "lib/Kconfig.debug"
> -
> -config EARLY_PRINTK
> - bool "Early printk" if EMBEDDED && DEBUG_KERNEL
> - default y
> - help
> - Write kernel log output directly into the VGA buffer or to a serial
> - port.
...
> --- /dev/null
> +++ linux-2.6.24-rc1/arch/x86/Kconfig.debug
> @@ -0,0 +1,119 @@
> +menu "Kernel hacking"
> +
> +config TRACE_IRQFLAGS_SUPPORT
> + def_bool y
> +
> +source "lib/Kconfig.debug"
> +
> +config EARLY_PRINTK
> + bool "Early printk" if EMBEDDED && DEBUG_KERNEL
> + default y
> + depends on X86_32
> + help
> + Write kernel log output directly into the VGA buffer or to a serial
> + port.
> +
> + This is useful for kernel debugging when your machine crashes very
> + early before the console code is initialized. For normal operation
> + it is not recommended because it looks ugly and doesn't cooperate
> + with klogd/syslogd or the X server. You should normally N here,
> + unless you want to debug such a crash.
> +
...
in x86_64/Kconfig has EARLY_PRINTK too

config EARLY_PRINTK
bool
default y

YH