The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Brownell <david-b@pacbell.net>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg KH <greg@kroah.com>
Subject: Re: [patch 2.6.24-rc1] resource_len() utility function
Date: Wed, 24 Oct 2007 22:08:17 -0400	[thread overview]
Message-ID: <471FFA91.3040306@garzik.org> (raw)
In-Reply-To: <20071025024405.3e960e9c@the-village.bc.nu>

Alan Cox wrote:
> On Wed, 24 Oct 2007 18:20:52 -0700
> David Brownell <david-b@pacbell.net> wrote:
> 
>> Add a new resource_len() function, so drivers can start using this
>> instead of driver-private code for a common idiom.  The call can be
>> useful with at least:
>>
>>  - request_region(), release_region()
>>  - request_mem_region(), release_mem_region()
>>  - ioremap()
>>
>> Candidate drivers include those using platform or PNP busses, and
>> maybe some others.  PCI already has a similar function.
>>
>> This patch also updates a representative set of drivers in two
>> subsystems to use this call (SPI, and USB peripheral/gadget).
> 
> PCI also increasingly is using functions that allow the user to choose to
> map a resource as a resource (eg pci_iomap). So is it better to have
> functions request_mem_resource(res)  free_mem_resource(res) and similar
> instead or as well ?


With regards to resource reservation...  IMO we should mimic struct 
pci_dev and add struct resource[] to struct device.

Just like we have pci_request_regions(), we should also be able to 
easily to a dev_request_regions().  the implementation should be very 
close to pci_request_region() and pci_release_region().

Then a dev_iomap() analogue to pci_iomap() should be pretty 
straightforward to create.

	Jeff



  reply	other threads:[~2007-10-25  2:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25  1:20 [patch 2.6.24-rc1] resource_len() utility function David Brownell
2007-10-25  1:44 ` Alan Cox
2007-10-25  2:08   ` Jeff Garzik [this message]
2007-10-25  2:47     ` David Brownell
2007-10-25  3:46       ` Jeff Garzik
2007-10-25  4:38         ` David Brownell
2007-10-25 12:29           ` Alan Cox
2007-10-25 16:31             ` David Brownell
2007-10-25  2:39   ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471FFA91.3040306@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox