From: KaiGai Kohei <kaigai@ak.jp.nec.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
jffs-dev@axis.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make jffs2_get_acl() static
Date: Thu, 25 Oct 2007 11:19:29 +0900 [thread overview]
Message-ID: <471FFD31.3020405@ak.jp.nec.com> (raw)
In-Reply-To: <20071024162734.GU30533@stusta.de>
Adrian Bunk wrote:
> jffs2_get_acl() can now become static again.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: KaiGai Kohei <kaigai@ak.jp.nec.com>
> ---
>
> fs/jffs2/acl.c | 2 +-
> fs/jffs2/acl.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> add2b887d64536f3fe978e62f0774292456f1ddb
> diff --git a/fs/jffs2/acl.c b/fs/jffs2/acl.c
> index 9728614..b14e805 100644
> --- a/fs/jffs2/acl.c
> +++ b/fs/jffs2/acl.c
> @@ -176,7 +176,7 @@ static void jffs2_iset_acl(struct inode *inode, struct posix_acl **i_acl, struct
> spin_unlock(&inode->i_lock);
> }
>
> -struct posix_acl *jffs2_get_acl(struct inode *inode, int type)
> +static struct posix_acl *jffs2_get_acl(struct inode *inode, int type)
> {
> struct jffs2_inode_info *f = JFFS2_INODE_INFO(inode);
> struct posix_acl *acl;
> diff --git a/fs/jffs2/acl.h b/fs/jffs2/acl.h
> index 76c6ebd..0bb7f00 100644
> --- a/fs/jffs2/acl.h
> +++ b/fs/jffs2/acl.h
> @@ -28,7 +28,6 @@ struct jffs2_acl_header {
>
> #define JFFS2_ACL_NOT_CACHED ((void *)-1)
>
> -extern struct posix_acl *jffs2_get_acl(struct inode *inode, int type);
> extern int jffs2_permission(struct inode *, int, struct nameidata *);
> extern int jffs2_acl_chmod(struct inode *);
> extern int jffs2_init_acl_pre(struct inode *, struct inode *, int *);
> @@ -40,7 +39,6 @@ extern struct xattr_handler jffs2_acl_default_xattr_handler;
>
> #else
>
> -#define jffs2_get_acl(inode, type) (NULL)
> #define jffs2_permission (NULL)
> #define jffs2_acl_chmod(inode) (0)
> #define jffs2_init_acl_pre(dir_i,inode,mode) (0)
>
>
prev parent reply other threads:[~2007-10-25 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:27 [2.6 patch] make jffs2_get_acl() static Adrian Bunk
2007-10-25 2:19 ` KaiGai Kohei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471FFD31.3020405@ak.jp.nec.com \
--to=kaigai@ak.jp.nec.com \
--cc=bunk@kernel.org \
--cc=dwmw2@infradead.org \
--cc=jffs-dev@axis.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox