From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charles Han <hanchunchao@inspur.com>,
vireshk@kernel.org, andriy.shevchenko@linux.intel.com,
vkoul@kernel.org, miquel.raynal@bootlin.com,
ilpo.jarvinen@linux.intel.com
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: dw: dmamux: Add NULL check in rzn1_dmamux_route_allocate()
Date: Tue, 17 Jun 2025 08:10:24 +0200 [thread overview]
Message-ID: <471c85c8-b49d-4fc4-991e-933cedf47a93@kernel.org> (raw)
In-Reply-To: <20250616104810.2222-1-hanchunchao@inspur.com>
On 16/06/2025 12:48, Charles Han wrote:
> The function of_find_device_by_node() may return NULL if the device
> node cannot be found or CONFIG_OF is not defined, dereferencing
> it without NULL check may lead to NULL dereference.
> Add a check to verify whether the return value is NULL.
>
> Fixes: 134d9c52fca2 ("dmaengine: dw: dmamux: Introduce RZN1 DMA router support")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
> drivers/dma/dw/rzn1-dmamux.c | 10 ++++++++--
Don't send patches for a subsystem patch by patch, but organize your
work correctly into patchset so we can reply in one thread (instead of
10) that you are fixing non-existing problems.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-06-17 6:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 10:48 [PATCH] dmaengine: dw: dmamux: Add NULL check in rzn1_dmamux_route_allocate() Charles Han
2025-06-17 6:10 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471c85c8-b49d-4fc4-991e-933cedf47a93@kernel.org \
--to=krzk@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=hanchunchao@inspur.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).