Re: [2.6 patch] blackfin: "extern inline" -> "static inline"

["H. Peter Anvin" <hpa@zytor.com>]

Mike Frysinger wrote:
> On 10/24/07, Jie Zhang <jzhang.linux@gmail.com> wrote:
>> On 10/25/07, Adrian Bunk <bunk@kernel.org> wrote:
>>> "extern inline" will have different semantics with gcc 4.3.
>>>
>>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>>>
>>> --- a/include/asm-blackfin/string.h
>>> +++ b/include/asm-blackfin/string.h
>>> @@ -4,7 +4,7 @@
>>>  #ifdef __KERNEL__              /* only set these up for kernel code */
>>>
>>>  #define __HAVE_ARCH_STRCPY
>>> -extern inline char *strcpy(char *dest, const char *src)
>>> +static inline char *strcpy(char *dest, const char *src)
>>>  {
>>>         char *xdest = dest;
>>>         char temp = 0;
>> What if we compile it with gcc 4.1?
> 
> we'll have to either use the gcc attributes to force old inline
> behavior or use the gcc flag to force it

We should probably have an extern_inline define then, assuming this is a 
function that does exist in a linkable version already -- otherwise 
"static inline" is correct.

	-hpa