Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support

Eric W. Biederman
2007-10-25T17:02:43Z

"Huang, Ying" <ying.huang@intel.com> writes:

> +static void __init efi_call_phys_prelog(void) __acquires(efi_lock)
> +{
> + unsigned long vaddress;
> +
> + /*
> + * Lock sequence is different from normal case because
> + * efi_flags is global
> + */
> + spin_lock(&efi_lock);
> + local_irq_save(efi_flags);
> + early_runtime_code_mapping_set_exec(1);
> + vaddress = (unsigned long)__va(0x0UL);
> + pgd_val(save_pgd) = pgd_val(*pgd_offset_k(0x0UL));
> + set_pgd(pgd_offset_k(0x0UL), *pgd_offset_k(vaddress));
> + global_flush_tlb();
> +}
> +
> +static void __init efi_call_phys_epilog(void) __releases(efi_lock)
> +{
> + /*
> + * After the lock is released, the original page table is restored.
> + */
> + set_pgd(pgd_offset_k(0x0UL), save_pgd);
> + early_runtime_code_mapping_set_exec(0);
> + global_flush_tlb();
> + local_irq_restore(efi_flags);
> + spin_unlock(&efi_lock);
> +}
> +
> +static efi_status_t __init phys_efi_set_virtual_address_map(
> + unsigned long memory_map_size,
> + unsigned long descriptor_size,
> + u32 descriptor_version,
> + efi_memory_desc_t *virtual_map)
> +{
> + efi_status_t status;
> +
> + efi_call_phys_prelog();
> + status = lin2win4((void *)efi_phys.set_virtual_address_map,
> + (u64)memory_map_size, (u64)descriptor_size,
> + (u64)descriptor_version, (u64)virtual_map);
> + efi_call_phys_epilog();
> + return status;
> +}

So you still have this piece of code which makes a kernel using
efi not compatible with kexec. But you are still supporting a physical
call mode for efi. If you are going to do this can we please just
remove the hacks that make the EFI physical call mode early boot only
and just always use that mode. Depending on weird call once functions
like efi_set_virtual_address_map makes me very uncomfortable.

Eric