From: Jeff Garzik <jeff@garzik.org>
To: Karsten Keil <kkeil@suse.de>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ISDN/capidrv: fix casting warning
Date: Thu, 25 Oct 2007 20:53:58 -0400 [thread overview]
Message-ID: <47213AA6.6040909@garzik.org> (raw)
In-Reply-To: <20071025095111.GA22353@pingi.kke.suse.de>
Karsten Keil wrote:
> On Thu, Oct 25, 2007 at 04:06:16AM -0400, Jeff Garzik wrote:
>> drivers/isdn/capi/capidrv.c: In function 'if_sendbuf':
>> drivers/isdn/capi/capidrv.c:1865: warning: cast from pointer to integer
>> of different size
>>
>> We are passing a kernel pointer, skb->data, but the interface itself is
>> limited to 32 bits. A future changeset may want to mark this code
>> 32-bit only, if it turns out cmsg->Data value truncation on 64-bit
>> platforms is problematic in practice.
>>
>
> I think I should really add somewhere a comment for this issue.
> This field is not used in practice in linux kernel (neither in 32 or
> 64 bit), but should have some value, since a CAPI message trace will
> display it.
> The correct value in the 32 bit case is the address of the
> data, in 64 bit it makes no sense, maybe we should use 0 here.
So noted... I will make sure the next revision of the patch fulfills
all your wishes :)
Jeff
prev parent reply other threads:[~2007-10-26 0:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 8:06 [PATCH] sound/oss/sb_common.c: fix casting warning Jeff Garzik
2007-10-25 8:06 ` [PATCH] Permit silencing of __deprecated warnings Jeff Garzik
2007-10-25 8:15 ` Andrew Morton
2007-10-25 8:20 ` Jeff Garzik
2007-10-25 15:34 ` Linus Torvalds
2007-10-25 11:02 ` Sam Ravnborg
2007-10-26 3:07 ` Arjan van de Ven
2007-10-25 8:06 ` [PATCH] Remove #warnings for longstanding conditions Jeff Garzik
2007-10-25 9:52 ` Karsten Keil
2007-10-25 11:22 ` Matthew Wilcox
2007-10-26 2:07 ` Jeff Garzik
2007-10-26 2:14 ` Matthew Wilcox
2007-10-26 2:19 ` Jeff Garzik
2007-10-25 8:06 ` [PATCH] ISDN/capidrv: fix casting warning Jeff Garzik
2007-10-25 9:51 ` Karsten Keil
2007-10-26 0:53 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47213AA6.6040909@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox