From: Jeff Garzik <jeff@garzik.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org, akpm@linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Remove #warnings for longstanding conditions.
Date: Thu, 25 Oct 2007 22:07:17 -0400 [thread overview]
Message-ID: <47214BD5.4020106@garzik.org> (raw)
In-Reply-To: <20071025112231.GL27248@parisc-linux.org>
Matthew Wilcox wrote:
>> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
>> not properly converted to the DMA API
> I'll be removing this #warning from advansys when I get rid of the
> last bus_to_virt. Which I've already done ... it's just that the
> resulting driver works on i386, but crashes parisc, so there's clearly a
> bug. I haven't had time to track it down yet. So NACK this patch.
Well, two main questions...
Is this warning of value to anybody but you?
Is this information worth printing out on everyone else's kernel build?
If yes, great! But it sounds like this warning is analagous to
#warning willy's TODO list: get milk, buy groceries, read email, ...
which doesn't add much value to others' kernel builds :)
Jeff
next prev parent reply other threads:[~2007-10-26 2:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 8:06 [PATCH] sound/oss/sb_common.c: fix casting warning Jeff Garzik
2007-10-25 8:06 ` [PATCH] Permit silencing of __deprecated warnings Jeff Garzik
2007-10-25 8:15 ` Andrew Morton
2007-10-25 8:20 ` Jeff Garzik
2007-10-25 15:34 ` Linus Torvalds
2007-10-25 11:02 ` Sam Ravnborg
2007-10-26 3:07 ` Arjan van de Ven
2007-10-25 8:06 ` [PATCH] Remove #warnings for longstanding conditions Jeff Garzik
2007-10-25 9:52 ` Karsten Keil
2007-10-25 11:22 ` Matthew Wilcox
2007-10-26 2:07 ` Jeff Garzik [this message]
2007-10-26 2:14 ` Matthew Wilcox
2007-10-26 2:19 ` Jeff Garzik
2007-10-25 8:06 ` [PATCH] ISDN/capidrv: fix casting warning Jeff Garzik
2007-10-25 9:51 ` Karsten Keil
2007-10-26 0:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47214BD5.4020106@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox